Re: [PATCH 4.9 5/8] bcache: silence static checker warning

Sasha Levin
2019-11-25T13:47:44Z

On Fri, Nov 22, 2019 at 10:52:50AM +0000, Lee Jones wrote:
>From: Dan Carpenter <dan.carpenter@oracle.com>
>
>[ Upstream commit da22f0eea555baf9b0a84b52afe56db2052cfe8d ]
>
>In olden times, closure_return() used to have a hidden return built in.
>We removed the hidden return but forgot to add a new return here. If
>"c" were NULL we would oops on the next line, but fortunately "c" is
>never NULL. Let's just remove the if statement.

So this doesn't actually fix anything?

--
Thanks,
Sasha