[PATCH 4.9 5/8] bcache: silence static checker warning

Lee Jones
2019-11-22T11:14:41Z

From: Dan Carpenter <dan.carpenter@oracle.com>

[ Upstream commit da22f0eea555baf9b0a84b52afe56db2052cfe8d ]

In olden times, closure_return() used to have a hidden return built in.
We removed the hidden return but forgot to add a new return here. If
"c" were NULL we would oops on the next line, but fortunately "c" is
never NULL. Let's just remove the if statement.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/md/bcache/super.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index c5bc3e5e921e..3e113be966fe 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1397,9 +1397,6 @@ static void cache_set_flush(struct closure *cl)
struct btree *b;
unsigned i;

- if (!c)
- closure_return(cl);
-
bch_cache_accounting_destroy(&c->accounting);

kobject_put(&c->internal);
--
2.24.0