Re: [PATCH 4.9 8/8] ext4: avoid unnecessary stalls in ext4_evict_inode()

Sasha Levin
2019-11-25T13:48:37Z

On Fri, Nov 22, 2019 at 10:52:53AM +0000, Lee Jones wrote:
>From: Jan Kara <jack@suse.cz>
>
>[ Upstream commit 3abb1a0fc2871f2db52199e1748a1d48a54a3427 ]
>
>These days inode reclaim calls evict_inode() only when it has no pages
>in the mapping. In that case it is not necessary to wait for transaction
>commit in ext4_evict_inode() as there can be no pages waiting to be
>committed. So avoid unnecessary transaction waiting in that case.
>
>We still have to keep the check for the case where ext4_evict_inode()
>gets called from other paths (e.g. umount) where inode still can have
>some page cache pages.

This reads to me like an optimization?

--
Thanks,
Sasha