public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: chenyi.qiang@intel.com, pbonzini@redhat.com,
	xiaoyao.li@intel.com, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] KVM: X86: Fix initialization of MSR lists" failed to apply to 5.3-stable tree
Date: Mon, 25 Nov 2019 12:33:59 -0500	[thread overview]
Message-ID: <20191125173359.GH5861@sasha-vm> (raw)
In-Reply-To: <15740905382212@kroah.com>

On Mon, Nov 18, 2019 at 04:22:18PM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.3-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 7a5ee6edb42e0bb487954806d34877995b6b8d59 Mon Sep 17 00:00:00 2001
>From: Chenyi Qiang <chenyi.qiang@intel.com>
>Date: Wed, 6 Nov 2019 14:35:20 +0800
>Subject: [PATCH] KVM: X86: Fix initialization of MSR lists
>
>The three MSR lists(msrs_to_save[], emulated_msrs[] and
>msr_based_features[]) are global arrays of kvm.ko, which are
>adjusted (copy supported MSRs forward to override the unsupported MSRs)
>when insmod kvm-{intel,amd}.ko, but it doesn't reset these three arrays
>to their initial value when rmmod kvm-{intel,amd}.ko. Thus, at the next
>installation, kvm-{intel,amd}.ko will do operations on the modified
>arrays with some MSRs lost and some MSRs duplicated.
>
>So define three constant arrays to hold the initial MSR lists and
>initialize msrs_to_save[], emulated_msrs[] and msr_based_features[]
>based on the constant arrays.
>
>Cc: stable@vger.kernel.org
>Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
>Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
>[Remove now useless conditionals. - Paolo]
>Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Would it make sense taking the commits below to make this patch apply on
5.3?

7a5ee6edb42e ("KVM: X86: Fix initialization of MSR lists")
e2ada66ec418 ("kvm: x86: Add Intel PMU MSRs to msrs_to_save[]")
24c29b7ac0da ("KVM: x86: omit absent pmu MSRs from MSR list")
cf05a67b68b8 ("KVM: x86: omit "impossible" pmu MSRs from MSR list")

-- 
Thanks,
Sasha

      reply	other threads:[~2019-11-25 17:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18 15:22 FAILED: patch "[PATCH] KVM: X86: Fix initialization of MSR lists" failed to apply to 5.3-stable tree gregkh
2019-11-25 17:33 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191125173359.GH5861@sasha-vm \
    --to=sashal@kernel.org \
    --cc=chenyi.qiang@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=pbonzini@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox