Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: pasic@linux.ibm.com, mimu@linux.ibm.com, mst@redhat.com,
	stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] virtio_ring: fix return code on DMA mapping fails" failed to apply to 4.19-stable tree
Date: Tue, 26 Nov 2019 21:20:29 -0500	[thread overview]
Message-ID: <20191127022029.GM5861@sasha-vm> (raw)
In-Reply-To: <1574703866101156@kroah.com>

On Mon, Nov 25, 2019 at 06:44:26PM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.19-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From f7728002c1c7bfa787b276a31c3ef458739b8e7c Mon Sep 17 00:00:00 2001
>From: Halil Pasic <pasic@linux.ibm.com>
>Date: Thu, 14 Nov 2019 13:46:46 +0100
>Subject: [PATCH] virtio_ring: fix return code on DMA mapping fails
>
>Commit 780bc7903a32 ("virtio_ring: Support DMA APIs")  makes
>virtqueue_add() return -EIO when we fail to map our I/O buffers. This is
>a very realistic scenario for guests with encrypted memory, as swiotlb
>may run out of space, depending on it's size and the I/O load.
>
>The virtio-blk driver interprets -EIO form virtqueue_add() as an IO
>error, despite the fact that swiotlb full is in absence of bugs a
>recoverable condition.
>
>Let us change the return code to -ENOMEM, and make the block layer
>recover form these failures when virtio-blk encounters the condition
>described above.
>
>Cc: stable@vger.kernel.org
>Fixes: 780bc7903a32 ("virtio_ring: Support DMA APIs")
>Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
>Tested-by: Michael Mueller <mimu@linux.ibm.com>
>Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

The code got shuffled around a bit in 138fd2514863 ("virtio_ring: add
_split suffix for split ring functions"), I've cleaned it up and queued
it for 4.19, 4.14, and 4.9.

-- 
Thanks,
Sasha

      reply	other threads:[~2019-11-27  2:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 17:44 FAILED: patch "[PATCH] virtio_ring: fix return code on DMA mapping fails" failed to apply to 4.19-stable tree gregkh
2019-11-27  2:20 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191127022029.GM5861@sasha-vm \
    --to=sashal@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=mimu@linux.ibm.com \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox