stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Sasha Levin <sashal@kernel.org>
Cc: gregkh@linuxfoundation.org, wei.w.wang@intel.com,
	david@redhat.com, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] virtio_balloon: fix shrinker count" failed to apply to 4.19-stable tree
Date: Wed, 27 Nov 2019 09:30:55 -0500	[thread overview]
Message-ID: <20191127093031-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20191127022359.GN5861@sasha-vm>

On Tue, Nov 26, 2019 at 09:23:59PM -0500, Sasha Levin wrote:
> On Mon, Nov 25, 2019 at 06:44:42PM +0100, gregkh@linuxfoundation.org wrote:
> > 
> > The patch below does not apply to the 4.19-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> > 
> > thanks,
> > 
> > greg k-h
> > 
> > ------------------ original commit in Linus's tree ------------------
> > 
> > From c9a6820fc0da2603be3054ee7590eb9f350508a7 Mon Sep 17 00:00:00 2001
> > From: Wei Wang <wei.w.wang@intel.com>
> > Date: Tue, 19 Nov 2019 05:02:33 -0500
> > Subject: [PATCH] virtio_balloon: fix shrinker count
> > 
> > Instead of multiplying by page order, virtio balloon divided by page
> > order. The result is that it can return 0 if there are a bit less
> > than MAX_ORDER - 1 pages in use, and then shrinker scan won't be called.
> > 
> > Cc: stable@vger.kernel.org
> > Fixes: 71994620bb25 ("virtio_balloon: replace oom notifier with shrinker")
> > Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Reviewed-by: David Hildenbrand <david@redhat.com>
> 
> I think that the fixes tag should be pointing to 86a559787e6f
> ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT"), and this commit
> isn't needed on 4.19.

I believe you are right but don't see a way to fix that as the patch is
upstream.

> -- 
> Thanks,
> Sasha


      reply	other threads:[~2019-11-27 14:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 17:44 FAILED: patch "[PATCH] virtio_balloon: fix shrinker count" failed to apply to 4.19-stable tree gregkh
2019-11-27  2:23 ` Sasha Levin
2019-11-27 14:30   ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191127093031-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=david@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=wei.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).