From: Lee Jones <lee.jones@linaro.org>
To: Greg KH <greg@kroah.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 4.4 1/6] can: dev: can_dellink(): remove return at end of void function
Date: Wed, 27 Nov 2019 09:54:41 +0000 [thread overview]
Message-ID: <20191127095441.GM3296@dell> (raw)
In-Reply-To: <20191127075115.GB1821634@kroah.com>
On Wed, 27 Nov 2019, Greg KH wrote:
> On Wed, Nov 27, 2019 at 07:21:19AM +0000, Lee Jones wrote:
> > From: Marc Kleine-Budde <mkl@pengutronix.de>
> >
> > [ Upstream commit d36673f5918c8fd3533f7c0d4bac041baf39c7bb ]
> >
> > This patch remove the return at the end of the void function
> > can_dellink().
> >
> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/net/can/dev.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
> > index 9dd968ee792e..e0d067701edc 100644
> > --- a/drivers/net/can/dev.c
> > +++ b/drivers/net/can/dev.c
> > @@ -1041,7 +1041,6 @@ static int can_newlink(struct net *src_net, struct net_device *dev,
> >
> > static void can_dellink(struct net_device *dev, struct list_head *head)
> > {
> > - return;
> > }
> >
> > static struct rtnl_link_ops can_link_ops __read_mostly = {
>
> Also, this showed up in 5.4, so why did you not include it in all of
> your patch series that you sent? I can't take patches for older kernels
> and skip newer ones for no good reason.
Right. I pulled it from the other branches as it wasn't suitable.
Looks like this was left behind.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2019-11-27 9:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 7:21 [PATCH 4.4 1/6] can: dev: can_dellink(): remove return at end of void function Lee Jones
2019-11-27 7:21 ` [PATCH 4.4 2/6] arm64: fix for bad_mode() handler to always result in panic Lee Jones
2019-11-27 7:21 ` [PATCH 4.4 3/6] cpufreq: Skip cpufreq resume if it's not suspended Lee Jones
2019-11-27 7:21 ` [PATCH 4.4 4/6] dm: use blk_set_queue_dying() in __dm_destroy() Lee Jones
2019-11-27 7:21 ` [PATCH 4.4 5/6] mmc: block: Fix tag condition with packed writes Lee Jones
2019-11-27 7:21 ` [PATCH 4.4 6/6] ocfs2: remove ocfs2_is_o2cb_active() Lee Jones
2019-11-27 7:50 ` [PATCH 4.4 1/6] can: dev: can_dellink(): remove return at end of void function Greg KH
2019-11-27 7:51 ` Greg KH
2019-11-27 9:54 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127095441.GM3296@dell \
--to=lee.jones@linaro.org \
--cc=greg@kroah.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).