From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B73C432C0 for ; Wed, 27 Nov 2019 20:38:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 31FF7215B2 for ; Wed, 27 Nov 2019 20:38:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887111; bh=zYJRsokSNnbLuG9oKacMYr6iwcJAcDKTNZpXfdZ7Apc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LAZlZSwWfGoTgu5dcdJ16M55LlikJDMoifAPhGqgr7VDrFNnIKFeaR1r80g0D19Uc /iTtvoCJeU8COIcjG8sec+9qr4CNT3HdRH3kuvdzHEX268MsVD3tr6vmIM1ZWKxfzg ez137+xerZo2ItDvQOew2rfYIDZGQL/AKf10VKqY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728707AbfK0Uia (ORCPT ); Wed, 27 Nov 2019 15:38:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:42086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727073AbfK0Ui0 (ORCPT ); Wed, 27 Nov 2019 15:38:26 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B75B215A4; Wed, 27 Nov 2019 20:38:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887105; bh=zYJRsokSNnbLuG9oKacMYr6iwcJAcDKTNZpXfdZ7Apc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FiaatHy9l3Yp4UKoosw2IXhz5aF7YscQAtvLMqRpEpGZN2Pn4l/f/GvP21Fk7v4CY Nqrs+g7T4VHjiiTLOkHFECNgBdFFldHcYoLyRjs0TwfaEs401qpO1ruCRBcr7EMPJN iVOz34dvnkCkfw+bETo78aDMM+A5InegB8569VqI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+d93dff37e6a89431c158@syzkaller.appspotmail.com, Oliver Neukum , Sean Young , Mauro Carvalho Chehab Subject: [PATCH 4.4 113/132] media: b2c2-flexcop-usb: add sanity checking Date: Wed, 27 Nov 2019 21:31:44 +0100 Message-Id: <20191127203030.791717735@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127202857.270233486@linuxfoundation.org> References: <20191127202857.270233486@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Oliver Neukum commit 1b976fc6d684e3282914cdbe7a8d68fdce19095c upstream. The driver needs an isochronous endpoint to be present. It will oops in its absence. Add checking for it. Reported-by: syzbot+d93dff37e6a89431c158@syzkaller.appspotmail.com Signed-off-by: Oliver Neukum Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/b2c2/flexcop-usb.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/media/usb/b2c2/flexcop-usb.c +++ b/drivers/media/usb/b2c2/flexcop-usb.c @@ -508,6 +508,9 @@ static int flexcop_usb_probe(struct usb_ struct flexcop_device *fc = NULL; int ret; + if (intf->cur_altsetting->desc.bNumEndpoints < 1) + return -ENODEV; + if ((fc = flexcop_device_kmalloc(sizeof(struct flexcop_usb))) == NULL) { err("out of memory\n"); return -ENOMEM;