From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BADDEC432C0 for ; Wed, 27 Nov 2019 20:53:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E3F2218AE for ; Wed, 27 Nov 2019 20:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887990; bh=4jRCHwt9FzNoPULeqAk5ypyYV4J5S/YfCSXAZc9W2f4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ts3EfYLq3JnBW1PnFGXciX7N3DTHCe12SfhwFCGKM0+ZsseY+BX4ELG/fhlfpvGAl pDPD3RmyMHU68PbVS6B0DnLXYXuPkCCIQWpVBzbr5PJj0fZNPC51qur9Sldrs3K4Ea Uip0EYKzYDAgPPg4IZeKbQKROdvr1VSn/xqXaI6U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730674AbfK0Uw7 (ORCPT ); Wed, 27 Nov 2019 15:52:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:41072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730668AbfK0Uw6 (ORCPT ); Wed, 27 Nov 2019 15:52:58 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 954B9218DE; Wed, 27 Nov 2019 20:52:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887978; bh=4jRCHwt9FzNoPULeqAk5ypyYV4J5S/YfCSXAZc9W2f4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WrfVGf09AiAinA4jQJhOMCu+MZIrWj3n4MtEYujK0CVLL6n9yrDD3+tiGt0a6AC6I 2dtcPhaIamqkgHlImAD50+OselyNIIk/3RLulFIVtOqdWd027Eqnk8uPdtrvtsvw5X ipDDLI8BDfrwTdAV5P465sJG7cXkr0qEUY8jL/Fk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rajkumar Manoharan , "John W. Linville" , Kalle Valo , "David S. Miller" , Denis Efremov Subject: [PATCH 4.14 167/211] ath9k_hw: fix uninitialized variable data Date: Wed, 27 Nov 2019 21:31:40 +0100 Message-Id: <20191127203109.660466493@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203049.431810767@linuxfoundation.org> References: <20191127203049.431810767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Denis Efremov commit 80e84f36412e0c5172447b6947068dca0d04ee82 upstream. Currently, data variable in ar9003_hw_thermo_cal_apply() could be uninitialized if ar9300_otp_read_word() will fail to read the value. Initialize data variable with 0 to prevent an undefined behavior. This will be enough to handle error case when ar9300_otp_read_word() fails. Fixes: 80fe43f2bbd5 ("ath9k_hw: Read and configure thermocal for AR9462") Cc: Rajkumar Manoharan Cc: John W. Linville Cc: Kalle Valo Cc: "David S. Miller" Cc: stable@vger.kernel.org Signed-off-by: Denis Efremov Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c +++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c @@ -4116,7 +4116,7 @@ static void ar9003_hw_thermometer_apply( static void ar9003_hw_thermo_cal_apply(struct ath_hw *ah) { - u32 data, ko, kg; + u32 data = 0, ko, kg; if (!AR_SREV_9462_20_OR_LATER(ah)) return;