From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3159FC2BC73 for ; Wed, 4 Dec 2019 18:22:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08D7A21555 for ; Wed, 4 Dec 2019 18:22:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575483724; bh=G+dN70EWZVxlSDhL9Zb00I684se8PKnfRkgk/5cWS/o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lT8vkgFJeNzudcVSEfPqjcFCg+oTPDjw0BJ/0FHYmp2uHl+kUPsZ4Zgy7g8tC7SI1 i0BQvko8mRmWfC7l+RLvZ4IEIY5015vHrJ4eTXM8dMcV1+B2gr9teg3y33R90MCUCN 8jGjCJRCudYBtbQOeTzj4KDLme1BQiZ/eirlZ9hE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730438AbfLDSFo (ORCPT ); Wed, 4 Dec 2019 13:05:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:52790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730433AbfLDSFn (ORCPT ); Wed, 4 Dec 2019 13:05:43 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B141520659; Wed, 4 Dec 2019 18:05:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482743; bh=G+dN70EWZVxlSDhL9Zb00I684se8PKnfRkgk/5cWS/o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qO2RUI5ruaHxUQpb2S20WSBv6ScFWYeuwSwMFdYjxQJat6xkjLJnM1ev9hEoxQZqw UtwOaEMRGyvLwwM4R223e6YQS09gXh6hvbRplki1bBcHu2iu9dQTq9Ik8Q2nr4K24J 9TDGCsNcU52loluoo7XfMLI41qZtapbn6zLFCEhs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 117/209] tipc: fix a missing check of genlmsg_put Date: Wed, 4 Dec 2019 18:55:29 +0100 Message-Id: <20191204175331.183836454@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175321.609072813@linuxfoundation.org> References: <20191204175321.609072813@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Kangjie Lu [ Upstream commit 46273cf7e009231d2b6bc10a926e82b8928a9fb2 ] genlmsg_put could fail. The fix inserts a check of its return value, and if it fails, returns -EMSGSIZE. Signed-off-by: Kangjie Lu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/tipc/netlink_compat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index 1c8ac0c11008c..91d51a595ac23 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -974,6 +974,8 @@ static int tipc_nl_compat_publ_dump(struct tipc_nl_compat_msg *msg, u32 sock) hdr = genlmsg_put(args, 0, 0, &tipc_genl_family, NLM_F_MULTI, TIPC_NL_PUBL_GET); + if (!hdr) + return -EMSGSIZE; nest = nla_nest_start(args, TIPC_NLA_SOCK); if (!nest) { -- 2.20.1