Re: [PATCH v3 09/15] ASoC: tegra: Add fallback for audio mclk

[Greg KH <greg@kroah.com>]

On Fri, Dec 06, 2019 at 08:19:26AM -0800, Sowjanya Komatineni wrote:
> 
> On 12/5/19 11:09 PM, Greg KH wrote:
> > On Thu, Dec 05, 2019 at 06:47:12PM -0800, Sowjanya Komatineni wrote:
> > > mclk is from clk_out_1 which is part of Tegra PMC block and pmc clocks
> > > are moved to Tegra PMC driver with pmc as clock provider and using pmc
> > > clock ids.
> > > 
> > > New device tree uses clk_out_1 from pmc clock provider.
> > > 
> > > So, this patch adds fallback to extern1 in case of retrieving mclk fails
> > > to be backward compatible of new device tree with older kernels.
> > > 
> > > Cc: stable@vger.kernel.org
> > > 
> > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> > > ---
> > >   sound/soc/tegra/tegra_asoc_utils.c | 10 ++++++++--
> > >   1 file changed, 8 insertions(+), 2 deletions(-)
> > <formletter>
> > 
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree.  Please read:
> >      https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> > for how to do this properly.
> > 
> > </formletter>
> 
> Hi Greg,
> 
> link says to option-1 is strongly preferred for for all patches except for
> submissions that are not in net/ and security related.
> 
> Option-1 is to add Cc: stable@vger.kernel.org in sign-off area and I
> followed this.

That's fine, but then why did you just email a patch to yourself and the
list?  Shouldn't you also submit the patch upstream to get it properly
merged first?

thanks,

greg k-h