[PATCH v3 09/15] ASoC: tegra: Add fallback for audio mclk

[PATCH v3 09/15] ASoC: tegra: Add fallback for audio mclk

[Sowjanya Komatineni]

mclk is from clk_out_1 which is part of Tegra PMC block and pmc clocks
are moved to Tegra PMC driver with pmc as clock provider and using pmc
clock ids.

New device tree uses clk_out_1 from pmc clock provider.

So, this patch adds fallback to extern1 in case of retrieving mclk fails
to be backward compatible of new device tree with older kernels.

Cc: stable@vger.kernel.org

Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
 sound/soc/tegra/tegra_asoc_utils.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/sound/soc/tegra/tegra_asoc_utils.c b/sound/soc/tegra/tegra_asoc_utils.c
index 8e3a3740df7c..f7408d5240c0 100644
--- a/sound/soc/tegra/tegra_asoc_utils.c
+++ b/sound/soc/tegra/tegra_asoc_utils.c
@@ -211,8 +211,14 @@ int tegra_asoc_utils_init(struct tegra_asoc_utils_data *data,
 	data->clk_cdev1 = clk_get(dev, "mclk");
 	if (IS_ERR(data->clk_cdev1)) {
 		dev_err(data->dev, "Can't retrieve clk cdev1\n");
-		ret = PTR_ERR(data->clk_cdev1);
-		goto err_put_pll_a_out0;
+		data->clk_cdev1 = clk_get_sys("clk_out_1", "extern1");
+		if (IS_ERR(data->clk_cdev1)) {
+			dev_err(data->dev, "Can't retrieve clk extern1\n");
+			ret = PTR_ERR(data->clk_cdev1);
+			goto err_put_pll_a_out0;
+		}
+
+		dev_err(data->dev, "Falling back to extern1\n");
 	}
 
 	/*
-- 
2.7.4

Re: [PATCH v3 09/15] ASoC: tegra: Add fallback for audio mclk

[Greg KH]

On Thu, Dec 05, 2019 at 06:47:12PM -0800, Sowjanya Komatineni wrote:
> mclk is from clk_out_1 which is part of Tegra PMC block and pmc clocks
> are moved to Tegra PMC driver with pmc as clock provider and using pmc
> clock ids.
> 
> New device tree uses clk_out_1 from pmc clock provider.
> 
> So, this patch adds fallback to extern1 in case of retrieving mclk fails
> to be backward compatible of new device tree with older kernels.
> 
> Cc: stable@vger.kernel.org
> 
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> ---
>  sound/soc/tegra/tegra_asoc_utils.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

Re: [PATCH v3 09/15] ASoC: tegra: Add fallback for audio mclk

[Sowjanya Komatineni]

On 12/5/19 11:09 PM, Greg KH wrote:
> On Thu, Dec 05, 2019 at 06:47:12PM -0800, Sowjanya Komatineni wrote:
>> mclk is from clk_out_1 which is part of Tegra PMC block and pmc clocks
>> are moved to Tegra PMC driver with pmc as clock provider and using pmc
>> clock ids.
>>
>> New device tree uses clk_out_1 from pmc clock provider.
>>
>> So, this patch adds fallback to extern1 in case of retrieving mclk fails
>> to be backward compatible of new device tree with older kernels.
>>
>> Cc: stable@vger.kernel.org
>>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>>   sound/soc/tegra/tegra_asoc_utils.c | 10 ++++++++--
>>   1 file changed, 8 insertions(+), 2 deletions(-)
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>      https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>

Hi Greg,

link says to option-1 is strongly preferred for for all patches except 
for submissions that are not in net/ and security related.

Option-1 is to add Cc: stable@vger.kernel.org in sign-off area and I 
followed this.

Please help if I miss understood your feedback.

Thanks



-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

Re: [PATCH v3 09/15] ASoC: tegra: Add fallback for audio mclk

[Greg KH]

On Fri, Dec 06, 2019 at 08:19:26AM -0800, Sowjanya Komatineni wrote:
> 
> On 12/5/19 11:09 PM, Greg KH wrote:
> > On Thu, Dec 05, 2019 at 06:47:12PM -0800, Sowjanya Komatineni wrote:
> > > mclk is from clk_out_1 which is part of Tegra PMC block and pmc clocks
> > > are moved to Tegra PMC driver with pmc as clock provider and using pmc
> > > clock ids.
> > > 
> > > New device tree uses clk_out_1 from pmc clock provider.
> > > 
> > > So, this patch adds fallback to extern1 in case of retrieving mclk fails
> > > to be backward compatible of new device tree with older kernels.
> > > 
> > > Cc: stable@vger.kernel.org
> > > 
> > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> > > ---
> > >   sound/soc/tegra/tegra_asoc_utils.c | 10 ++++++++--
> > >   1 file changed, 8 insertions(+), 2 deletions(-)
> > <formletter>
> > 
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree.  Please read:
> >      https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> > for how to do this properly.
> > 
> > </formletter>
> 
> Hi Greg,
> 
> link says to option-1 is strongly preferred for for all patches except for
> submissions that are not in net/ and security related.
> 
> Option-1 is to add Cc: stable@vger.kernel.org in sign-off area and I
> followed this.

That's fine, but then why did you just email a patch to yourself and the
list?  Shouldn't you also submit the patch upstream to get it properly
merged first?

thanks,

greg k-h

Re: [PATCH v3 09/15] ASoC: tegra: Add fallback for audio mclk

[Sowjanya Komatineni]

On 12/6/19 8:29 AM, Greg KH wrote:
> On Fri, Dec 06, 2019 at 08:19:26AM -0800, Sowjanya Komatineni wrote:
>> On 12/5/19 11:09 PM, Greg KH wrote:
>>> On Thu, Dec 05, 2019 at 06:47:12PM -0800, Sowjanya Komatineni wrote:
>>>> mclk is from clk_out_1 which is part of Tegra PMC block and pmc clocks
>>>> are moved to Tegra PMC driver with pmc as clock provider and using pmc
>>>> clock ids.
>>>>
>>>> New device tree uses clk_out_1 from pmc clock provider.
>>>>
>>>> So, this patch adds fallback to extern1 in case of retrieving mclk fails
>>>> to be backward compatible of new device tree with older kernels.
>>>>
>>>> Cc: stable@vger.kernel.org
>>>>
>>>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>>>> ---
>>>>    sound/soc/tegra/tegra_asoc_utils.c | 10 ++++++++--
>>>>    1 file changed, 8 insertions(+), 2 deletions(-)
>>> <formletter>
>>>
>>> This is not the correct way to submit patches for inclusion in the
>>> stable kernel tree.  Please read:
>>>       https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>>> for how to do this properly.
>>>
>>> </formletter>
>> Hi Greg,
>>
>> link says to option-1 is strongly preferred for for all patches except for
>> submissions that are not in net/ and security related.
>>
>> Option-1 is to add Cc: stable@vger.kernel.org in sign-off area and I
>> followed this.
> That's fine, but then why did you just email a patch to yourself and the
> list?  Shouldn't you also submit the patch upstream to get it properly
> merged first?
>
> thanks,
>
> greg k-h

I set patches to the mailing list as per get_maintainers script.

Do I need to add any other alias to get patch applied for stable kernel 
other than cc tag?




-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

Re: [PATCH v3 09/15] ASoC: tegra: Add fallback for audio mclk

[Sowjanya Komatineni]

On 12/6/19 9:11 AM, Sowjanya Komatineni wrote:
>
> On 12/6/19 8:29 AM, Greg KH wrote:
>> On Fri, Dec 06, 2019 at 08:19:26AM -0800, Sowjanya Komatineni wrote:
>>> On 12/5/19 11:09 PM, Greg KH wrote:
>>>> On Thu, Dec 05, 2019 at 06:47:12PM -0800, Sowjanya Komatineni wrote:
>>>>> mclk is from clk_out_1 which is part of Tegra PMC block and pmc 
>>>>> clocks
>>>>> are moved to Tegra PMC driver with pmc as clock provider and using 
>>>>> pmc
>>>>> clock ids.
>>>>>
>>>>> New device tree uses clk_out_1 from pmc clock provider.
>>>>>
>>>>> So, this patch adds fallback to extern1 in case of retrieving mclk 
>>>>> fails
>>>>> to be backward compatible of new device tree with older kernels.
>>>>>
>>>>> Cc: stable@vger.kernel.org
>>>>>
>>>>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>>>>> ---
>>>>>    sound/soc/tegra/tegra_asoc_utils.c | 10 ++++++++--
>>>>>    1 file changed, 8 insertions(+), 2 deletions(-)
>>>> <formletter>
>>>>
>>>> This is not the correct way to submit patches for inclusion in the
>>>> stable kernel tree.  Please read:
>>>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html 
>>>>
>>>> for how to do this properly.
>>>>
>>>> </formletter>
>>> Hi Greg,
>>>
>>> link says to option-1 is strongly preferred for for all patches 
>>> except for
>>> submissions that are not in net/ and security related.
>>>
>>> Option-1 is to add Cc: stable@vger.kernel.org in sign-off area and I
>>> followed this.
>> That's fine, but then why did you just email a patch to yourself and the
>> list?  Shouldn't you also submit the patch upstream to get it properly
>> merged first?
>>
>> thanks,
>>
>> greg k-h
>
> I set patches to the mailing list as per get_maintainers script.
>
> Do I need to add any other alias to get patch applied for stable 
> kernel other than cc tag?
>
Does this patch need to be sent separate to upstream (not part of this 
series) with cc stable tag?
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

Re: [PATCH v3 09/15] ASoC: tegra: Add fallback for audio mclk

[Greg KH]

On Fri, Dec 06, 2019 at 09:15:20AM -0800, Sowjanya Komatineni wrote:
> -----------------------------------------------------------------------------------
> This email message is for the sole use of the intended recipient(s) and may contain
> confidential information.  Any unauthorized review, use, disclosure or distribution
> is prohibited.  If you are not the intended recipient, please contact the sender by
> reply email and destroy all copies of the original message.
> -----------------------------------------------------------------------------------

Now deleted, this is not compatible with public mailing lists, sorry.