From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1710DC00454 for ; Tue, 10 Dec 2019 21:52:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFEF5205C9 for ; Tue, 10 Dec 2019 21:52:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576014754; bh=bd3btlXj2DwEvZWfcI8iM0UOzO0Wslo27RrHimZBZxk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ThPxTV/EeM+3YBm2Rry7i7sGjDs0qHMRfXm5fkWXeWZH/wktl3CvLt5IAzqHN1ew0 UZsSb630ylyvGFbRZ6vIm9XqWyXP5R+kqVhyM2dw0QFse1mUo5xJGO9dCCqw61HZaX q2SFY6kZpDswJrS14aYgfxR3N8U9RbrH32ywgJI0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727238AbfLJVHm (ORCPT ); Tue, 10 Dec 2019 16:07:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:54074 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727190AbfLJVHl (ORCPT ); Tue, 10 Dec 2019 16:07:41 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 666AE24681; Tue, 10 Dec 2019 21:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576012061; bh=bd3btlXj2DwEvZWfcI8iM0UOzO0Wslo27RrHimZBZxk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p1ZzVd68EdRRKAQ618r9t3t42U+NNN+cDvBceNnO9emuA4qrjNqrS7fM+WtUaDaWb Ce0NC8cni0twmNlXRFW4OYTKSHQMXOvAs2FD1oLeyvXHxo+sA63fViJIG7AgN/Coop kjaWkOvEJQx5lDyrrDidzsxfSB+P4qudnea9BeXo= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Benoit Parrot , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 043/350] media: i2c: ov2659: Fix missing 720p register config Date: Tue, 10 Dec 2019 16:02:28 -0500 Message-Id: <20191210210735.9077-4-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191210210735.9077-1-sashal@kernel.org> References: <20191210210735.9077-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Benoit Parrot [ Upstream commit 9d669fbfca20e6035ead814e55d9ef1a6b500540 ] The initial registers sequence is only loaded at probe time. Afterward only the resolution and format specific register are modified. Care must be taken to make sure registers modified by one resolution setting are reverted back when another resolution is programmed. This was not done properly for the 720p case. Signed-off-by: Benoit Parrot Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/ov2659.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c index 70bf63b9dbd04..e1ff38009cf07 100644 --- a/drivers/media/i2c/ov2659.c +++ b/drivers/media/i2c/ov2659.c @@ -419,10 +419,14 @@ static struct sensor_register ov2659_720p[] = { { REG_TIMING_YINC, 0x11 }, { REG_TIMING_VERT_FORMAT, 0x80 }, { REG_TIMING_HORIZ_FORMAT, 0x00 }, + { 0x370a, 0x12 }, { 0x3a03, 0xe8 }, { 0x3a09, 0x6f }, { 0x3a0b, 0x5d }, { 0x3a15, 0x9a }, + { REG_VFIFO_READ_START_H, 0x00 }, + { REG_VFIFO_READ_START_L, 0x80 }, + { REG_ISP_CTRL02, 0x00 }, { REG_NULL, 0x00 }, }; -- 2.20.1