From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 965FAC00454 for ; Wed, 11 Dec 2019 16:07:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62386208C3 for ; Wed, 11 Dec 2019 16:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576080470; bh=HY3j7n3byT9QT0It2CXSCU9ZX3FuttIs9KmwYNh5x4w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MGHxgn+FPADQg/NXq0z7lhrqB1+tdgIRTQbKqukbcLN6WZQhA6uXY7GLVaFIuKC0A HAHQiSaK3ly2L4T+MzA8J2yZJf5EpY49gFrlfdnjHhVVMlGKC8Mwb+jjU9UXtreAQA AFBb0tQ55OB7oMo+KR3jbaVdpud1GuJzD/5OBTOA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731111AbfLKQHs (ORCPT ); Wed, 11 Dec 2019 11:07:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:33950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731117AbfLKPMZ (ORCPT ); Wed, 11 Dec 2019 10:12:25 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B2384208C3; Wed, 11 Dec 2019 15:12:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077144; bh=HY3j7n3byT9QT0It2CXSCU9ZX3FuttIs9KmwYNh5x4w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WGZbdKlJmVMuw6yi5NztOCK9kWDqeZL/t4xFOgJtWey4UdT5y3GOw3B90h2kOguv9 6rJFhSFRqvqPK18XxlIdbY8bpMAaLNxgvDIWKUzZj1C+ajfhJxya2tW40QBZXtcW5M /nVIA4hKeaqhChpJc04tmUlgQsRltdPwejFM1RBo= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Krzysztof Kozlowski , Peng Ma , Vinod Koul , Sasha Levin , dmaengine@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 031/134] dmaengine: fsl-qdma: Handle invalid qdma-queue0 IRQ Date: Wed, 11 Dec 2019 10:10:07 -0500 Message-Id: <20191211151150.19073-31-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191211151150.19073-1-sashal@kernel.org> References: <20191211151150.19073-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Krzysztof Kozlowski [ Upstream commit 41814c4eadf8a791b6d07114f96e7e120e59555c ] platform_get_irq_byname() might return -errno which later would be cast to an unsigned int and used in IRQ handling code leading to usage of wrong ID and errors about wrong irq_base. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Peng Ma Tested-by: Peng Ma Link: https://lore.kernel.org/r/20191004150826.6656-1-krzk@kernel.org Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/fsl-qdma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c index 06664fbd2d911..89792083d62c5 100644 --- a/drivers/dma/fsl-qdma.c +++ b/drivers/dma/fsl-qdma.c @@ -1155,6 +1155,9 @@ static int fsl_qdma_probe(struct platform_device *pdev) return ret; fsl_qdma->irq_base = platform_get_irq_byname(pdev, "qdma-queue0"); + if (fsl_qdma->irq_base < 0) + return fsl_qdma->irq_base; + fsl_qdma->feature = of_property_read_bool(np, "big-endian"); INIT_LIST_HEAD(&fsl_qdma->dma_dev.channels); -- 2.20.1