From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEDD6C00454 for ; Wed, 11 Dec 2019 15:12:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A51B2467D for ; Wed, 11 Dec 2019 15:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077149; bh=oh40QEE5ttlEKYSROoAylS8040I4r7PyyUN5hmOebRI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=famO4f8vqvJtYVcesmxm6qSruWHRNZGmu79rEU48YDOpRZbhQub5WuQL/QItCmVL4 YHWLdQgW7vso+Gk2ey7/Qh3+F4EsOjyIbgpNcTAmmkq8MeKL3HdPjggQKQZyqJuCEi ztBHWsAn3gFljxc/WrIpSceTzMymyXZnPQg4ZrUU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731133AbfLKPM2 (ORCPT ); Wed, 11 Dec 2019 10:12:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:34076 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731127AbfLKPM1 (ORCPT ); Wed, 11 Dec 2019 10:12:27 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EBCC0222C4; Wed, 11 Dec 2019 15:12:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077146; bh=oh40QEE5ttlEKYSROoAylS8040I4r7PyyUN5hmOebRI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F9w8tbhXuk/fcsExp84PQnemUKrYtyS/REnkgyIhdXuX0sCy/MJFnR3r4wnwrdBEH HpHf2Ko/YObWeADwcXQjKCEDyVfia0v+1fr0lzPomaBqkTOAE3yeM7yQLxjeh6rx6X SABESV3cARdq0bTQ4eJ5MU/Ed1/eoGsJxyEjl4UE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chuhong Yuan , Pavel Machek , Sasha Levin , linux-leds@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 033/134] leds: an30259a: add a check for devm_regmap_init_i2c Date: Wed, 11 Dec 2019 10:10:09 -0500 Message-Id: <20191211151150.19073-33-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191211151150.19073-1-sashal@kernel.org> References: <20191211151150.19073-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Chuhong Yuan [ Upstream commit fc7b5028f2627133c7c18734715a08829eab4d1f ] an30259a_probe misses a check for devm_regmap_init_i2c and may cause problems. Add a check and print errors like other leds drivers. Signed-off-by: Chuhong Yuan Signed-off-by: Pavel Machek Signed-off-by: Sasha Levin --- drivers/leds/leds-an30259a.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/leds/leds-an30259a.c b/drivers/leds/leds-an30259a.c index 250dc9d6f6350..82350a28a5644 100644 --- a/drivers/leds/leds-an30259a.c +++ b/drivers/leds/leds-an30259a.c @@ -305,6 +305,13 @@ static int an30259a_probe(struct i2c_client *client) chip->regmap = devm_regmap_init_i2c(client, &an30259a_regmap_config); + if (IS_ERR(chip->regmap)) { + err = PTR_ERR(chip->regmap); + dev_err(&client->dev, "Failed to allocate register map: %d\n", + err); + goto exit; + } + for (i = 0; i < chip->num_leds; i++) { struct led_init_data init_data = {}; -- 2.20.1