From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6492CC43603 for ; Sat, 14 Dec 2019 08:43:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 456222465B for ; Sat, 14 Dec 2019 08:43:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725876AbfLNInA (ORCPT ); Sat, 14 Dec 2019 03:43:00 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:37034 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbfLNInA (ORCPT ); Sat, 14 Dec 2019 03:43:00 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 940251C25FC; Sat, 14 Dec 2019 09:42:58 +0100 (CET) Date: Sat, 14 Dec 2019 09:42:58 +0100 From: Pavel Machek To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Chuhong Yuan , linux-leds@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.4 033/134] leds: an30259a: add a check for devm_regmap_init_i2c Message-ID: <20191214084258.GC16834@duo.ucw.cz> References: <20191211151150.19073-1-sashal@kernel.org> <20191211151150.19073-33-sashal@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yVhtmJPUSI46BTXb" Content-Disposition: inline In-Reply-To: <20191211151150.19073-33-sashal@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org --yVhtmJPUSI46BTXb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2019-12-11 10:10:09, Sasha Levin wrote: > From: Chuhong Yuan >=20 > [ Upstream commit fc7b5028f2627133c7c18734715a08829eab4d1f ] >=20 > an30259a_probe misses a check for devm_regmap_init_i2c and may cause > problems. > Add a check and print errors like other leds drivers. Please drop. Pavel > Signed-off-by: Chuhong Yuan > Signed-off-by: Pavel Machek > Signed-off-by: Sasha Levin > --- > drivers/leds/leds-an30259a.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/drivers/leds/leds-an30259a.c b/drivers/leds/leds-an30259a.c > index 250dc9d6f6350..82350a28a5644 100644 > --- a/drivers/leds/leds-an30259a.c > +++ b/drivers/leds/leds-an30259a.c > @@ -305,6 +305,13 @@ static int an30259a_probe(struct i2c_client *client) > =20 > chip->regmap =3D devm_regmap_init_i2c(client, &an30259a_regmap_config); > =20 > + if (IS_ERR(chip->regmap)) { > + err =3D PTR_ERR(chip->regmap); > + dev_err(&client->dev, "Failed to allocate register map: %d\n", > + err); > + goto exit; > + } > + > for (i =3D 0; i < chip->num_leds; i++) { > struct led_init_data init_data =3D {}; > =20 > --=20 > 2.20.1 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --yVhtmJPUSI46BTXb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXfSgkgAKCRAw5/Bqldv6 8v1wAJ9gd7l3Y6sYuUg30GQElhPfZZgwbACeNxKs8yWJBc+Zx7cq4qpRGXe6nXQ= =1Hfy -----END PGP SIGNATURE----- --yVhtmJPUSI46BTXb--