From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81B0EC43603 for ; Sun, 15 Dec 2019 17:32:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 459C62467A for ; Sun, 15 Dec 2019 17:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576431148; bh=iouhilPIr9mNparKJDFaxSKVppgDdgkm9jVhINcT06o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GePA0/Q1Q9RdzIO2D5nmtm/wmisFUAGUurVZ/5yYX3NNJP0loP8GKyHHS1Ih+Pe02 +JhFKMs2KECwqYUIp8r/n5bifGpA0Bfci4sBFjkIvS1dQi9StHAuB5BuFfE17XgVkO HR2Bh18HCxsbJZbX8tCLCWX9h8yHZFjsue5FPtMQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726267AbfLORc2 (ORCPT ); Sun, 15 Dec 2019 12:32:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:36462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbfLORc1 (ORCPT ); Sun, 15 Dec 2019 12:32:27 -0500 Received: from localhost (unknown [73.61.17.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ADC1E24679; Sun, 15 Dec 2019 17:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576431147; bh=iouhilPIr9mNparKJDFaxSKVppgDdgkm9jVhINcT06o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gEn/OXY++ZLxY7dB/6b0zRUBJrABIp/ALCPgGTXNlmHuqAWHaJU6lxLWphaE4z9tW hFVlOd871I3HyPYGGgMjq//MYKSiBaCfT4VjmrDEBrLy5JJf9xMibhCSA2WKrefw9r P6MquKPrTfiIsyh5aj4T+PzBaNrbMz5MkJb2bKo8= Date: Sun, 15 Dec 2019 12:32:25 -0500 From: Sasha Levin To: gregkh@linuxfoundation.org Cc: qutran@marvell.com, aeasi@marvell.com, emilne@redhat.com, hmadhani@marvell.com, martin.petersen@oracle.com, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] scsi: qla2xxx: Fix double scsi_done for abort path" failed to apply to 5.3-stable tree Message-ID: <20191215173225.GE18043@sasha-vm> References: <157633589722494@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <157633589722494@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sat, Dec 14, 2019 at 04:04:57PM +0100, gregkh@linuxfoundation.org wrote: > >The patch below does not apply to the 5.3-stable tree. >If someone wants it applied there, or to any other stable or longterm >tree, then please email the backport, including the original git commit >id to . > >thanks, > >greg k-h > >------------------ original commit in Linus's tree ------------------ > >>From f45bca8c5052e8c59bab64ee90c44441678b9a52 Mon Sep 17 00:00:00 2001 >From: Quinn Tran >Date: Tue, 5 Nov 2019 07:06:54 -0800 >Subject: [PATCH] scsi: qla2xxx: Fix double scsi_done for abort path > >Current code assumes abort will remove the original command from the active >list where scsi_done will not be called. Instead, the eh_abort thread will >do the scsi_done. That is not the case. Instead, we have a double >scsi_done calls triggering use after free. > >Abort will tell FW to release the command from FW possesion. The original >command will return to ULP with error in its normal fashion via scsi_done. >eh_abort path would wait for the original command completion before >returning. eh_abort path will not perform the scsi_done call. > >Fixes: 219d27d7147e0 ("scsi: qla2xxx: Fix race conditions in the code for aborting SCSI commands") >Cc: stable@vger.kernel.org # 5.2 >Link: https://lore.kernel.org/r/20191105150657.8092-6-hmadhani@marvell.com >Reviewed-by: Ewan D. Milne >Signed-off-by: Quinn Tran >Signed-off-by: Arun Easi >Signed-off-by: Himanshu Madhani >Signed-off-by: Martin K. Petersen I took these two additional patches to resolve the conflict: 85cffefa09e4 ("scsi: qla2xxx: Fix a race condition between aborting and completing a SCSI command") bdb61b9b944d ("scsi: qla2xxx: Introduce the function qla2xxx_init_sp()") -- Thanks, Sasha