From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FC32C43603 for ; Sun, 15 Dec 2019 17:40:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 655852467B for ; Sun, 15 Dec 2019 17:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576431637; bh=BwAk8X04GCEqqw7Lxo9ipSDWCImLJ6KhGzzXCFoxBIk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=cScN1QU7mWhUfvoIjNVTLt0oUmX2GmZx4KM/iuaKHc5bwWcW3GX3rQmqm2UtZcQEC 1lQqHHiE48cwzln0FwHvxY1q6uKtw9LDdTXZFoL4PLFnidw/bVHZAJz40YaYxJALnf lWTyB8UchepLOHKcw+ZBfJV/7sn1JvBfa5jI7RQ4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726470AbfLORkh (ORCPT ); Sun, 15 Dec 2019 12:40:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:39564 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726462AbfLORkg (ORCPT ); Sun, 15 Dec 2019 12:40:36 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB0852072B; Sun, 15 Dec 2019 17:40:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576431636; bh=BwAk8X04GCEqqw7Lxo9ipSDWCImLJ6KhGzzXCFoxBIk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XhNWMvcJoPeQNM7KhjkD7rRFft42ugXD4ceMgOhsy4pvGccCU80OtQ0mgD3f7mEZz tRKjh9H0e0XDE8XkdAJtcFjjUWkJxwDhVQRpzJ4VnRQkOBbOVPWDO/eyt7nGCVZDMe LF4NeWo6Dvw6C/wcOnlcQSQCKRDtGMiB/z1MB+Ak= Date: Sun, 15 Dec 2019 18:40:34 +0100 From: Greg KH To: Sasha Levin Cc: qutran@marvell.com, aeasi@marvell.com, emilne@redhat.com, hmadhani@marvell.com, martin.petersen@oracle.com, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] scsi: qla2xxx: Fix double scsi_done for abort path" failed to apply to 5.3-stable tree Message-ID: <20191215174034.GB855550@kroah.com> References: <157633589722494@kroah.com> <20191215173225.GE18043@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191215173225.GE18043@sasha-vm> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sun, Dec 15, 2019 at 12:32:25PM -0500, Sasha Levin wrote: > On Sat, Dec 14, 2019 at 04:04:57PM +0100, gregkh@linuxfoundation.org wrote: > > > > The patch below does not apply to the 5.3-stable tree. > > If someone wants it applied there, or to any other stable or longterm > > tree, then please email the backport, including the original git commit > > id to . > > > > thanks, > > > > greg k-h > > > > ------------------ original commit in Linus's tree ------------------ > > > > > From f45bca8c5052e8c59bab64ee90c44441678b9a52 Mon Sep 17 00:00:00 2001 > > From: Quinn Tran > > Date: Tue, 5 Nov 2019 07:06:54 -0800 > > Subject: [PATCH] scsi: qla2xxx: Fix double scsi_done for abort path > > > > Current code assumes abort will remove the original command from the active > > list where scsi_done will not be called. Instead, the eh_abort thread will > > do the scsi_done. That is not the case. Instead, we have a double > > scsi_done calls triggering use after free. > > > > Abort will tell FW to release the command from FW possesion. The original > > command will return to ULP with error in its normal fashion via scsi_done. > > eh_abort path would wait for the original command completion before > > returning. eh_abort path will not perform the scsi_done call. > > > > Fixes: 219d27d7147e0 ("scsi: qla2xxx: Fix race conditions in the code for aborting SCSI commands") > > Cc: stable@vger.kernel.org # 5.2 > > Link: https://lore.kernel.org/r/20191105150657.8092-6-hmadhani@marvell.com > > Reviewed-by: Ewan D. Milne > > Signed-off-by: Quinn Tran > > Signed-off-by: Arun Easi > > Signed-off-by: Himanshu Madhani > > Signed-off-by: Martin K. Petersen > > I took these two additional patches to resolve the conflict: > > 85cffefa09e4 ("scsi: qla2xxx: Fix a race condition between aborting and completing a SCSI command") > bdb61b9b944d ("scsi: qla2xxx: Introduce the function qla2xxx_init_sp()") Thanks for fixing up all of these scsi patches, much appreciated. greg k-h