From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 898E4C2D0CD for ; Mon, 16 Dec 2019 18:12:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61EF624650 for ; Mon, 16 Dec 2019 18:12:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519971; bh=cDrDGBDk6oXaOO6XSqMr574ZbPBCo63cBd4LFc0NzN8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rc6iKFaCrWZe9Zb3MuWD8TWwGykmrIx4G3dTI1GLT8ykMZk4qFj1QD+W7bgR8F9MM AynmL23rYq5Pq4x7WZtAFceoRjf6LChjsiYM0QPDov0DE5J74tz9OIBjOqErXPKDlH UrNQ8gehiVfrxpLv2JEqZi9X2STvWHAFbGYNFB44= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730590AbfLPSMu (ORCPT ); Mon, 16 Dec 2019 13:12:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:58244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727110AbfLPSMt (ORCPT ); Mon, 16 Dec 2019 13:12:49 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E7EB420CC7; Mon, 16 Dec 2019 18:12:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519969; bh=cDrDGBDk6oXaOO6XSqMr574ZbPBCo63cBd4LFc0NzN8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2FO2LOItAnPDu59Z/QNFTRdkKkyYoh22yIxb+3HHVG/p7qTPvcAtjpo5PcXPL38hH tcJfGhZbPRycADdhLTNwF/d6KqzreNyCxQWhpOW+OKXXPjpKnX57m+Sh4YwOTTCMbB Gsd8tmwJmTDm+dsaQY3KhiJy0ZgzbcXrW2qZDky4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Himanshu Madhani , Bart Van Assche , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.3 143/180] scsi: qla2xxx: Make qla2x00_abort_srb() again decrease the sp reference count Date: Mon, 16 Dec 2019 18:49:43 +0100 Message-Id: <20191216174843.248552703@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174806.018988360@linuxfoundation.org> References: <20191216174806.018988360@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Bart Van Assche [ Upstream commit d2d2b5a5741d317bed1fa38211f1f3b142d8cf7a ] Since qla2x00_abort_srb() starts with increasing the reference count of @sp, decrease that same reference count before returning. Cc: Himanshu Madhani Fixes: 219d27d7147e ("scsi: qla2xxx: Fix race conditions in the code for aborting SCSI commands") # v5.2. Signed-off-by: Bart Van Assche Tested-by: Himanshu Madhani Reviewed-by: Himanshu Madhani Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_os.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index ef75897b27132..82f6ae4dcfc0b 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -1751,6 +1751,8 @@ static void qla2x00_abort_srb(struct qla_qpair *qp, srb_t *sp, const int res, spin_lock_irqsave(qp->qp_lock_ptr, *flags); sp->comp = NULL; } + + atomic_dec(&sp->ref_count); } static void -- 2.20.1