From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A38C43603 for ; Mon, 16 Dec 2019 17:53:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AEB222464 for ; Mon, 16 Dec 2019 17:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576518780; bh=P3fHYkF8uiwCRNGqsqGZ22zNSpDc/wgJmZ4ibWm9yMQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RNEnTz9C2dpnF/KdS/9oqv2NMghgBIDnnAePK96l5aMA+dHLrtkHLhbQPUGu2ZYZi LrB2tGccyjrXZu8VyIrDKYEBYrBqM/rAEv5tJfYhL1x1Cg/xK2wCtvQLo4LbWRWHyP 0MWI8uc9E8QzEKADvDY20FodPPzI3DdSLRigyKG4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727047AbfLPRw6 (ORCPT ); Mon, 16 Dec 2019 12:52:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:45850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726976AbfLPRw6 (ORCPT ); Mon, 16 Dec 2019 12:52:58 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B3D02176D; Mon, 16 Dec 2019 17:52:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576518777; bh=P3fHYkF8uiwCRNGqsqGZ22zNSpDc/wgJmZ4ibWm9yMQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r5cSuNrtGMMyJAJ2tk/mk6NsOFkQnNOsqrDnPI8bwvhgI+72kCfgiJkNkBVfqEN3B kxIInEW61bLhQT4ARjAygdrj26y4batqr0azT+2KC7Zmn1+XHPmTHdBxD+XoeN6CaD LUMa6GGnZtvKab+HrtZelGg2Kw48EEHCs5ranRYw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arjun Vynipadath , Ganesh Goudar , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 023/267] cxgb4vf: fix memleak in mac_hlist initialization Date: Mon, 16 Dec 2019 18:45:49 +0100 Message-Id: <20191216174851.465350278@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174848.701533383@linuxfoundation.org> References: <20191216174848.701533383@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arjun Vynipadath [ Upstream commit 24357e06ba511ad874d664d39475dbb01c1ca450 ] mac_hlist was initialized during adapter_up, which will be called every time a vf device is first brought up, or every time when device is brought up again after bringing all devices down. This means our state of previous list is lost, causing a memleak if entries are present in the list. To fix that, move list init to the condition that performs initial one time adapter setup. Signed-off-by: Arjun Vynipadath Signed-off-by: Ganesh Goudar Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c index 8996ebbd222e0..26ba18ea08c6a 100644 --- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c @@ -714,6 +714,10 @@ static int adapter_up(struct adapter *adapter) if (adapter->flags & USING_MSIX) name_msix_vecs(adapter); + + /* Initialize hash mac addr list*/ + INIT_LIST_HEAD(&adapter->mac_hlist); + adapter->flags |= FULL_INIT_DONE; } @@ -739,8 +743,6 @@ static int adapter_up(struct adapter *adapter) enable_rx(adapter); t4vf_sge_start(adapter); - /* Initialize hash mac addr list*/ - INIT_LIST_HEAD(&adapter->mac_hlist); return 0; } -- 2.20.1