From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05BE9C43603 for ; Thu, 19 Dec 2019 19:00:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B9EC4222C2 for ; Thu, 19 Dec 2019 19:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576782021; bh=iGXz/x6xZIxMlB36RE7c/0DO5szquI6BsXtST0kPL2s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Uqb8GKymdrPNs8VMBu4yrLSTI+kX5U1naN/BkzQxWY2dfDny0NXfaDZv/h37BasKx u7V4cKX00UwmXsUn4AwZgLtmShc7xDGJQu6BFyQca0j11oMUHlPc+bs12ARjAfpZHY fq01hdEhTAJuzL1lpe7IHArsIveJaCHXu8a0JiCs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730009AbfLSSwQ (ORCPT ); Thu, 19 Dec 2019 13:52:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:46776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730246AbfLSSwP (ORCPT ); Thu, 19 Dec 2019 13:52:15 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 74F07227BF; Thu, 19 Dec 2019 18:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576781534; bh=iGXz/x6xZIxMlB36RE7c/0DO5szquI6BsXtST0kPL2s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tcRFFGi1FLQ2fBT7LBCxX2VCjAxXFCV+sX3osWWVKuUzmbHQNP2Egnk4oJMgNEyRH PCdTZkPZsFcd3oH6DQpLXCdTfF2IbJxXja2gDkn0WvDnr5dljpcaYBdyCzgG7tLwBD FVQR9SK/jPD4LPtfAU7tt4nN2+u50i+dKmMjWXks= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chris Lew , Bjorn Andersson Subject: [PATCH 4.19 24/47] rpmsg: glink: Set tail pointer to 0 at end of FIFO Date: Thu, 19 Dec 2019 19:34:38 +0100 Message-Id: <20191219182929.172042662@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191219182857.659088743@linuxfoundation.org> References: <20191219182857.659088743@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Chris Lew commit 4623e8bf1de0b86e23a56cdb39a72f054e89c3bd upstream. When wrapping around the FIFO, the remote expects the tail pointer to be reset to 0 on the edge case where the tail equals the FIFO length. Fixes: caf989c350e8 ("rpmsg: glink: Introduce glink smem based transport") Cc: stable@vger.kernel.org Signed-off-by: Chris Lew Signed-off-by: Bjorn Andersson Signed-off-by: Greg Kroah-Hartman --- drivers/rpmsg/qcom_glink_smem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/rpmsg/qcom_glink_smem.c +++ b/drivers/rpmsg/qcom_glink_smem.c @@ -105,7 +105,7 @@ static void glink_smem_rx_advance(struct tail = le32_to_cpu(*pipe->tail); tail += count; - if (tail > pipe->native.length) + if (tail >= pipe->native.length) tail -= pipe->native.length; *pipe->tail = cpu_to_le32(tail);