From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2EC4C2D0C1 for ; Thu, 19 Dec 2019 18:53:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A89622468C for ; Thu, 19 Dec 2019 18:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576781609; bh=79g9pLY07WZmLFOzBXbMh+TNjI7ClABAga+/NDBVIk4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=IQH2GcZMDBaTSt5yQgCdynwgH3OLON/Iw2nFgQfS+Zwl1n30ly4hPhc5LUQWFg0Q1 XnmnlGQT1uarbRLpM5R6fFII/Ke5CeNEeHL290yFqSuehTOivH62MQl0S+B2BeYuhQ n8S+c3dqSyX8b0o4Ipls337VQpuYSUicAIl/kcOY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730385AbfLSSx2 (ORCPT ); Thu, 19 Dec 2019 13:53:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:48548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730208AbfLSSx2 (ORCPT ); Thu, 19 Dec 2019 13:53:28 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3E36D2468C; Thu, 19 Dec 2019 18:53:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576781607; bh=79g9pLY07WZmLFOzBXbMh+TNjI7ClABAga+/NDBVIk4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0tc5plUpAmBSLhySkv0XDYYp/nbZ+M3mvDOCyArrnLKX1j//Yez0unkSRNWHunOb7 IPtkkuovodNW0WfuOASdyGyQOCP2sFJQyMVffQtmM5KAa537wBWZh2QG63TrxcmhMo kpM1584S0h8ziU4gj32CjE/WMfExaqb3/5mmwBG4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , Daniel Vetter Subject: [PATCH 4.19 40/47] dma-buf: Fix memory leak in sync_file_merge() Date: Thu, 19 Dec 2019 19:34:54 +0100 Message-Id: <20191219182946.667518659@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191219182857.659088743@linuxfoundation.org> References: <20191219182857.659088743@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Navid Emamdoost commit 6645d42d79d33e8a9fe262660a75d5f4556bbea9 upstream. In the implementation of sync_file_merge() the allocated sync_file is leaked if number of fences overflows. Release sync_file by goto err. Fixes: a02b9dc90d84 ("dma-buf/sync_file: refactor fence storage in struct sync_file") Signed-off-by: Navid Emamdoost Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20191122220957.30427-1-navid.emamdoost@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/dma-buf/sync_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/dma-buf/sync_file.c +++ b/drivers/dma-buf/sync_file.c @@ -230,7 +230,7 @@ static struct sync_file *sync_file_merge a_fences = get_fences(a, &a_num_fences); b_fences = get_fences(b, &b_num_fences); if (a_num_fences > INT_MAX - b_num_fences) - return NULL; + goto err; num_fences = a_num_fences + b_num_fences;