From: Greg KH <gregkh@linuxfoundation.org>
To: Laura Abbott <labbott@redhat.com>
Cc: Stefani Seibold <stefani@seibold.net>, stable@vger.kernel.org
Subject: Re: broken sound since 5.4.3
Date: Fri, 20 Dec 2019 07:28:46 +0100 [thread overview]
Message-ID: <20191220062846.GA2183748@kroah.com> (raw)
In-Reply-To: <240a7610-577a-8253-e880-b55182460c17@redhat.com>
On Thu, Dec 19, 2019 at 05:24:20PM -0500, Laura Abbott wrote:
> On 12/19/19 3:59 PM, Stefani Seibold wrote:
> > Hi,
> >
> > the current Linux Kernel is going kills my speakers of my monitor.
> >
> > Audio level is always 100 at percent.
> >
> > I broke down the issue to the following patch:
> >
> > diff --git a/sound/hda/hdac_stream.c b/sound/hda/hdac_stream.c
> > index d8fe7ff0cd58..f9707fb05efe 100644
> > --- a/sound/hda/hdac_stream.c
> > +++ b/sound/hda/hdac_stream.c
> > @@ -96,12 +96,14 @@ void snd_hdac_stream_start(struct hdac_stream *azx_dev, bool fresh_start)
> > 1 << azx_dev->index,
> > 1 << azx_dev->index);
> > /* set stripe control */
> > - if (azx_dev->substream)
> > - stripe_ctl = snd_hdac_get_stream_stripe_ctl(bus, azx_dev->substream);
> > - else
> > - stripe_ctl = 0;
> > - snd_hdac_stream_updateb(azx_dev, SD_CTL_3B, SD_CTL_STRIPE_MASK,
> > - stripe_ctl);
> > + if (azx_dev->stripe) {
> > + if (azx_dev->substream)
> > + stripe_ctl = snd_hdac_get_stream_stripe_ctl(bus, azx_dev->substream);
> > + else
> > + stripe_ctl = 0;
> > + snd_hdac_stream_updateb(azx_dev, SD_CTL_3B, SD_CTL_STRIPE_MASK,
> > + stripe_ctl);
> > + }
> > /* set DMA start and interrupt mask */
> > snd_hdac_stream_updateb(azx_dev, SD_CTL,
> > 0, SD_CTL_DMA_START | SD_INT_MASK);
> > @@ -118,7 +120,10 @@ void snd_hdac_stream_clear(struct hdac_stream *azx_dev)
> > snd_hdac_stream_updateb(azx_dev, SD_CTL,
> > SD_CTL_DMA_START | SD_INT_MASK, 0);
> > snd_hdac_stream_writeb(azx_dev, SD_STS, SD_INT_MASK); /* to be sure */
> > - snd_hdac_stream_updateb(azx_dev, SD_CTL_3B, SD_CTL_STRIPE_MASK, 0);
> > + if (azx_dev->stripe) {
> > + snd_hdac_stream_updateb(azx_dev, SD_CTL_3B, SD_CTL_STRIPE_MASK, 0);
> > + azx_dev->stripe = 0;
> > + }
> > azx_dev->running = false;
> > }
> > EXPORT_SYMBOL_GPL(snd_hdac_stream_clear);
> >
> >
> >
>
> I think this is fixed by 6fd739c04ffd ("ALSA: hda: Fix regression by strip mask fix")
> This is already tagged for stable but it would be nice to pick it up sooner.
Now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2019-12-20 6:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 20:59 broken sound since 5.4.3 Stefani Seibold
2019-12-19 22:24 ` Laura Abbott
2019-12-20 6:28 ` Greg KH [this message]
2019-12-20 7:30 ` Stefani Seibold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220062846.GA2183748@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=labbott@redhat.com \
--cc=stable@vger.kernel.org \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).