From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C07B3C2D0CE for ; Sun, 29 Dec 2019 18:18:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 911CB207E0 for ; Sun, 29 Dec 2019 18:18:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577643490; bh=ALFhbbApSdf4l2WXg7oZiq2+bihV32/+wcURhNG/0ZM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gxqkr0eIAqq8dc8BuJ6A2yvaL9iKaGfho5myBq7gqy+8cnSDPbfQWhjuuGayZDdQT aKuiF3FZ0IQMgLMxQ94qIy5L81MqTXEQQm6hFuE6IQ980LZ1R+IoSBu8OrENpx+Ljb 3OLx9nafVFufXRnafwymzbRUd2Z6/HhXESwQqD9s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727189AbfL2RWG (ORCPT ); Sun, 29 Dec 2019 12:22:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:37984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727169AbfL2RWD (ORCPT ); Sun, 29 Dec 2019 12:22:03 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1A7820CC7; Sun, 29 Dec 2019 17:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640122; bh=ALFhbbApSdf4l2WXg7oZiq2+bihV32/+wcURhNG/0ZM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2saSYvQCmZ2HffOeRtFDC/7d9o3OvdVCsQnapDJ4by4EBxyAvX/q9TXrsb/wNrSsV Vs4ErSq15D+KgMWxVD35lDQNExxLq0n9BXlVQq6eS+cIz5VedZri5UyaSWEU36pysn wYNYm7WBNDYjsgRrDtiglk+5SX7hydVuUqIA3GfM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Allen Pais , Kalle Valo , Sasha Levin Subject: [PATCH 4.14 027/161] libertas: fix a potential NULL pointer dereference Date: Sun, 29 Dec 2019 18:17:55 +0100 Message-Id: <20191229162406.262885647@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162355.500086350@linuxfoundation.org> References: <20191229162355.500086350@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Allen Pais [ Upstream commit 7da413a18583baaf35dd4a8eb414fa410367d7f2 ] alloc_workqueue is not checked for errors and as a result, a potential NULL dereference could occur. Signed-off-by: Allen Pais Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/marvell/libertas/if_sdio.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/marvell/libertas/if_sdio.c b/drivers/net/wireless/marvell/libertas/if_sdio.c index 39bf85d0ade0..c7f8a29d2606 100644 --- a/drivers/net/wireless/marvell/libertas/if_sdio.c +++ b/drivers/net/wireless/marvell/libertas/if_sdio.c @@ -1183,6 +1183,10 @@ static int if_sdio_probe(struct sdio_func *func, spin_lock_init(&card->lock); card->workqueue = alloc_workqueue("libertas_sdio", WQ_MEM_RECLAIM, 0); + if (unlikely(!card->workqueue)) { + ret = -ENOMEM; + goto err_queue; + } INIT_WORK(&card->packet_worker, if_sdio_host_to_card_worker); init_waitqueue_head(&card->pwron_waitq); @@ -1234,6 +1238,7 @@ err_activate_card: lbs_remove_card(priv); free: destroy_workqueue(card->workqueue); +err_queue: while (card->packets) { packet = card->packets; card->packets = card->packets->next; -- 2.20.1