From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D76D6C2D0DA for ; Sun, 29 Dec 2019 18:11:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9262206A4 for ; Sun, 29 Dec 2019 18:11:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577643098; bh=6B2gptAjSK2wVW8cOj99jBzyAYI7PCi1oglU0UXSJnk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=L0i/PGWrccgeVrcaMhuqaJAiwdThuvwHwmBQBh8eoKgz76OHcRA3ojUJoEbgSr6zv Z9PBQOm/e9MVGf3S1+1iU9P9AIGIivcieh2BuVW7Pja1Asc0GnwTv00Lwi8E8/AE91 tvljul46Mep9/3bw0tXkkJP2CSchot1LCMqofpY0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730405AbfL2SLd (ORCPT ); Sun, 29 Dec 2019 13:11:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:49784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730389AbfL2Rm6 (ORCPT ); Sun, 29 Dec 2019 12:42:58 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF7F0206A4; Sun, 29 Dec 2019 17:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577641377; bh=6B2gptAjSK2wVW8cOj99jBzyAYI7PCi1oglU0UXSJnk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NCGwFR06v9Wf0Mii/mLS53VFWaBwbTafFnnCpWsv3BMa8uB1SAVFDbKhVCm9nPL2a RXmAS5YNx2DOjbkOcs1M18tY9cRY/6EN7D/Ywjc7zY0KIvQ05dcZbd3bV0vIAAEa0Z FEayvucXGenE7ijjhPe6s0jiPX0r1/bdQrUQkMtg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai Subject: [PATCH 5.4 040/434] ALSA: hda/ca0132 - Keep power on during processing DSP response Date: Sun, 29 Dec 2019 18:21:33 +0100 Message-Id: <20191229172704.698827055@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229172702.393141737@linuxfoundation.org> References: <20191229172702.393141737@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Takashi Iwai commit 377bc0cfabce0244632dada19060839ced4e6949 upstream. We need to keep power on while processing the DSP response via unsol event. Each snd_hda_codec_read() call does the power management, so it should work normally, but still it's safer to keep the power up for the whole function. Fixes: a73d511c4867 ("ALSA: hda/ca0132: Add unsol handler for DSP and jack detection") Cc: Link: https://lore.kernel.org/r/20191213085111.22855-2-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_ca0132.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/pci/hda/patch_ca0132.c +++ b/sound/pci/hda/patch_ca0132.c @@ -7588,12 +7588,14 @@ static void ca0132_process_dsp_response( struct ca0132_spec *spec = codec->spec; codec_dbg(codec, "ca0132_process_dsp_response\n"); + snd_hda_power_up_pm(codec); if (spec->wait_scp) { if (dspio_get_response_data(codec) >= 0) spec->wait_scp = 0; } dspio_clear_response_queue(codec); + snd_hda_power_down_pm(codec); } static void hp_callback(struct hda_codec *codec, struct hda_jack_callback *cb)