From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73411C2D0C2 for ; Tue, 31 Dec 2019 11:02:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46789206D9 for ; Tue, 31 Dec 2019 11:02:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726643AbfLaLCh (ORCPT ); Tue, 31 Dec 2019 06:02:37 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:45666 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726658AbfLaLCh (ORCPT ); Tue, 31 Dec 2019 06:02:37 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 554DE1C2605; Tue, 31 Dec 2019 12:02:35 +0100 (CET) Date: Tue, 31 Dec 2019 12:02:34 +0100 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Faiz Abbas , Ulf Hansson Subject: Re: [PATCH 4.19 215/219] mmc: sdhci: Update the tuning failed messages to pr_debug level Message-ID: <20191231110234.GA14641@amd> References: <20191229162508.458551679@linuxfoundation.org> <20191229162542.999358059@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vkogqOf2sHV7VnPd" Content-Disposition: inline In-Reply-To: <20191229162542.999358059@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org --vkogqOf2sHV7VnPd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun 2019-12-29 18:20:17, Greg Kroah-Hartman wrote: > From: Faiz Abbas >=20 > commit 2c92dd20304f505b6ef43d206fff21bda8f1f0ae upstream. >=20 > Tuning support in DDR50 speed mode was added in SD Specifications Part1 > Physical Layer Specification v3.01. Its not possible to distinguish > between v3.00 and v3.01 from the SCR and that is why since > commit 4324f6de6d2e ("mmc: core: enable CMD19 tuning for DDR50 mode") > tuning failures are ignored in DDR50 speed mode. >=20 > Cards compatible with v3.00 don't respond to CMD19 in DDR50 and this > error gets printed during enumeration and also if retune is triggered at > any time during operation. Update the printk level to pr_debug so that > these errors don't lead to false error reports. Well, downgrading level might be ok, but people will still see the message in dmesg. > +++ b/drivers/mmc/host/sdhci.c > @@ -2244,8 +2244,8 @@ static void __sdhci_execute_tuning(struc > sdhci_send_tuning(host, opcode); > =20 > if (!host->tuning_done) { > - pr_info("%s: Tuning timeout, falling back to fixed sampling clock\n", > - mmc_hostname(host->mmc)); > + pr_debug("%s: Tuning timeout, falling back to fixed sampling clock\n", > + mmc_hostname(host->mmc)); Maybe adding something like "(this is expected on SD cards implementing phy specification v3.00)" to the user-visible text would be even better?=20 Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --vkogqOf2sHV7VnPd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl4LKsoACgkQMOfwapXb+vKHgACbBlWS6E/Nn/z1rfJwBpatiK/S SQIAoImGETp/MGWkJGSVdtofXsJmuf4p =h7c1 -----END PGP SIGNATURE----- --vkogqOf2sHV7VnPd--