From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 310F4C2D0DE for ; Thu, 2 Jan 2020 01:11:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED321215A4 for ; Thu, 2 Jan 2020 01:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577927519; bh=c6uvGuxIkZWQP6pf0O1zj+m1D68g9hbagQ6DzAMQypY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=knh1qpXQWBvG2wPddkRpdNP4KdHbh00rSADQmsqKBhxnipV1k/EsIqK4icYuyB9BY tvMRjVnM2WTZ1+ls/IoryPeRaPgrECL7VD0VUNjPiE+xwWFYH8mg3D8tPiNq//IsWh GaoY0Fq8VCOuLz380Fgt73ciu/ADsg0FaeV3aMSA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727487AbgABBL6 (ORCPT ); Wed, 1 Jan 2020 20:11:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:44222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbgABBL6 (ORCPT ); Wed, 1 Jan 2020 20:11:58 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63D1D208C3; Thu, 2 Jan 2020 01:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577927517; bh=c6uvGuxIkZWQP6pf0O1zj+m1D68g9hbagQ6DzAMQypY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lp1mFnFfjYSWll3xP51wZPEpHbn1lWRSor7cZpc7osD05RWFUHRecZZjMdCeP31aY 2hbU6QOHiGoLnyxkIJBtjh+nnTNB+SR8GLMA5BJtVK40LSW2nnasK6EuqnFSbYRGhE sSrOLQYRX5Wv9eau9wHRB97qi1R8BTkfrZZeXe48= Date: Wed, 1 Jan 2020 20:11:56 -0500 From: Sasha Levin To: gregkh@linuxfoundation.org Cc: jmattson@google.com, ebiggers@kernel.org, jacobhxu@google.com, pbonzini@redhat.com, pshier@google.com, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] kvm: x86: Host feature SSBD doesn't imply guest feature" failed to apply to 4.19-stable tree Message-ID: <20200102011156.GE16372@sasha-vm> References: <1577634666179186@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1577634666179186@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sun, Dec 29, 2019 at 04:51:06PM +0100, gregkh@linuxfoundation.org wrote: > >The patch below does not apply to the 4.19-stable tree. >If someone wants it applied there, or to any other stable or longterm >tree, then please email the backport, including the original git commit >id to . > >thanks, > >greg k-h > >------------------ original commit in Linus's tree ------------------ > >>From 396d2e878f92ec108e4293f1c77ea3bc90b414ff Mon Sep 17 00:00:00 2001 >From: Jim Mattson >Date: Fri, 13 Dec 2019 16:15:15 -0800 >Subject: [PATCH] kvm: x86: Host feature SSBD doesn't imply guest feature > SPEC_CTRL_SSBD > >The host reports support for the synthetic feature X86_FEATURE_SSBD >when any of the three following hardware features are set: > CPUID.(EAX=7,ECX=0):EDX.SSBD[bit 31] > CPUID.80000008H:EBX.AMD_SSBD[bit 24] > CPUID.80000008H:EBX.VIRT_SSBD[bit 25] > >Either of the first two hardware features implies the existence of the >IA32_SPEC_CTRL MSR, but CPUID.80000008H:EBX.VIRT_SSBD[bit 25] does >not. Therefore, CPUID.(EAX=7,ECX=0):EDX.SSBD[bit 31] should only be >set in the guest if CPUID.(EAX=7,ECX=0):EDX.SSBD[bit 31] or >CPUID.80000008H:EBX.AMD_SSBD[bit 24] is set on the host. > >Fixes: 0c54914d0c52a ("KVM: x86: use Intel speculation bugs and features as derived in generic x86 code") >Signed-off-by: Jim Mattson >Reviewed-by: Jacob Xu >Reviewed-by: Peter Shier >Cc: Paolo Bonzini >Cc: stable@vger.kernel.org >Reported-by: Eric Biggers >Signed-off-by: Paolo Bonzini I don't think that this is needed on 4.19 and older, but it would be nice if someone would ack. -- Thanks, Sasha