From: Jiri Olsa <jolsa@redhat.com>
To: Akemi Yagi <toracat@elrepo.org>
Cc: Gordan Bobic <gordan@redsleeve.org>,
stable@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ElRepo <contact@elrepo.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: 4.9.208 regression in perf building
Date: Sun, 5 Jan 2020 20:35:50 +0100 [thread overview]
Message-ID: <20200105193550.GA177781@krava> (raw)
In-Reply-To: <CABA31DrtCwUj-wzPP+dwUP+=jTOHnt8eoS+d+N2yfAn22W19vA@mail.gmail.com>
On Sun, Jan 05, 2020 at 10:21:25AM -0800, Akemi Yagi wrote:
> Adding Arnaldo and Jiri to the CC list.
>
> On Sun, Jan 5, 2020 at 9:01 AM Gordan Bobic <gordan@redsleeve.org> wrote:
> >
> > It looks like 4.9.208 introduces a build regression for perf:
> >
> > make -f /builddir/build/BUILD/kernel-4.9.208/linux-4.9.208-1.el7.x86_64/tools/build/Makefile.build
> > dir=. obj=perf
>
> > -c -o builtin-report.o builtin-report.c
> > builtin-report.c: In function ‘report__setup_sample_type’:
> > builtin-report.c:296:6: error: ‘dwarf_callchain_users’ undeclared
> > (first use in this function)
> > if (dwarf_callchain_users) {
> > ^
> > builtin-report.c:296:6: note: each undeclared identifier is reported
> > only once for each function it appears in
> > mv: cannot stat ‘./.builtin-report.o.tmp’: No such file or directory
> > make[3]: *** [builtin-report.o] Error 1
> > make[2]: *** [perf-in.o] Error 2
> > make[1]: *** [sub-make] Error 2
> > make: *** [all] Error 2
> >
> > 4,9.207 works fine.
>
> The regression was caused by the following patch:
>
> https://lore.kernel.org/lkml/20191021133834.25998-7-acme@kernel.org/
>
> To fix this, 'dwarf_callchain_users' needs to be declared.
hum, I see it's declared in callchain.h which is included in builtin-report.c
also I can't see that same stuff like you have on line 296.. what sources are you on?
could you please check with latest Arnaldo's perf/core?
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
thanks,
jirka
next prev parent reply other threads:[~2020-01-05 19:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAMx4oe38RytiyqWfYb=So8iC6N=8nebqy3DsekiT7A5DGjpe+w@mail.gmail.com>
2020-01-05 17:01 ` 4.9.208 regression in perf building Gordan Bobic
2020-01-05 18:21 ` Akemi Yagi
2020-01-05 19:35 ` Jiri Olsa [this message]
2020-01-05 20:06 ` Akemi Yagi
2020-01-05 22:25 ` Jiri Olsa
2020-01-06 0:42 ` Jin, Yao
2020-01-05 18:29 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200105193550.GA177781@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=contact@elrepo.org \
--cc=gordan@redsleeve.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=toracat@elrepo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).