From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AEFCC33C8C for ; Sun, 5 Jan 2020 22:25:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9A3821775 for ; Sun, 5 Jan 2020 22:25:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hKnng3t2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727186AbgAEWZN (ORCPT ); Sun, 5 Jan 2020 17:25:13 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:44334 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726851AbgAEWZM (ORCPT ); Sun, 5 Jan 2020 17:25:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578263112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WXQZVNbi2jXqlBZM+s/5rlRX1XCn+Y0pdW/hvxGZCSY=; b=hKnng3t2KyKGeKcn96zg2BIkA+c4bKWAAuIKy6LOwBtpwg252xqHn2on51n6rCclNWEnRt 999bMJblykSwPV/ADAMpEe9JVdUTRi3wfDKi5I+XVtyZjeItOXCdgxPQjsbV39RE1LyS3e tBqXisfhaS1o72u+knQ8dIAxJY9mY/s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-256-Ckek9IzbNvKbYeDPx_mXRw-1; Sun, 05 Jan 2020 17:25:08 -0500 X-MC-Unique: Ckek9IzbNvKbYeDPx_mXRw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EC2E3800D4C; Sun, 5 Jan 2020 22:25:06 +0000 (UTC) Received: from krava (ovpn-204-44.brq.redhat.com [10.40.204.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4CE2E7BFFC; Sun, 5 Jan 2020 22:25:05 +0000 (UTC) Date: Sun, 5 Jan 2020 23:25:02 +0100 From: Jiri Olsa To: Akemi Yagi Cc: Gordan Bobic , stable@vger.kernel.org, Linux Kernel Mailing List , ElRepo , Arnaldo Carvalho de Melo , Jiri Olsa Subject: Re: 4.9.208 regression in perf building Message-ID: <20200105222502.GA207350@krava> References: <20200105193550.GA177781@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Content-Transfer-Encoding: quoted-printable Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sun, Jan 05, 2020 at 12:06:07PM -0800, Akemi Yagi wrote: > On Sun, Jan 5, 2020 at 11:36 AM Jiri Olsa wrote: > > > > On Sun, Jan 05, 2020 at 10:21:25AM -0800, Akemi Yagi wrote: > > > Adding Arnaldo and Jiri to the CC list. > > > > > > On Sun, Jan 5, 2020 at 9:01 AM Gordan Bobic = wrote: > > > > > > > > It looks like 4.9.208 introduces a build regression for perf: > > > > > > > > make -f /builddir/build/BUILD/kernel-4.9.208/linux-4.9.208-1.el7.= x86_64/tools/build/Makefile.build > > > > dir=3D. obj=3Dperf > > > > > > > -c -o builtin-report.o builtin-report.c > > > > builtin-report.c: In function =E2=80=98report__setup_sample_type=E2= =80=99: > > > > builtin-report.c:296:6: error: =E2=80=98dwarf_callchain_users=E2=80= =99 undeclared > > > > (first use in this function) > > > > if (dwarf_callchain_users) { > > > > ^ > > > > builtin-report.c:296:6: note: each undeclared identifier is repor= ted > > > > only once for each function it appears in > > > > mv: cannot stat =E2=80=98./.builtin-report.o.tmp=E2=80=99: No suc= h file or directory > > > > make[3]: *** [builtin-report.o] Error 1 > > > > make[2]: *** [perf-in.o] Error 2 > > > > make[1]: *** [sub-make] Error 2 > > > > make: *** [all] Error 2 > > > > > > > > 4,9.207 works fine. > > > > > > The regression was caused by the following patch: > > > > > > https://lore.kernel.org/lkml/20191021133834.25998-7-acme@kernel.org= / > > > > > > To fix this, 'dwarf_callchain_users' needs to be declared. > > > > hum, I see it's declared in callchain.h which is included in builtin-= report.c > > also I can't see that same stuff like you have on line 296.. what sou= rces are you on? > > > > could you please check with latest Arnaldo's perf/core? > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > > > > thanks, > > jirka >=20 > This is kernel 4.4.208 that was released today. > 'dwarf_callchain_users' is not declared in this kernel. I'm afraid it > was missed when the aforementioned patch was backported. so 'dwarf_callchain_users' was introduced with: eabad8c6856f perf unwind: Do not look just at the global callchain_para= m.record_mode which wasn't backported to 4.4.y and it seems it will need more dependencies to be applied properly however if I revert aforementioned patch: faece3af8072 perf report: Add warning when libunwind not compiled in it compiles for me.. actualy I'm not sure why it went to stable, it's just user info/warning jirka