From: Sasha Levin <sashal@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: gregkh@linuxfoundation.org, stable@vger.kernel.org,
Aleksandr Yashkin <a.yashkin@inango-systems.com>
Subject: Re: [PATCH v4.9.z] pstore/ram: Write new dumps to start of recycled zones
Date: Tue, 7 Jan 2020 13:58:00 -0500 [thread overview]
Message-ID: <20200107185800.GB1706@sasha-vm> (raw)
In-Reply-To: <202001071023.9BFD4C51@keescook>
On Tue, Jan 07, 2020 at 10:25:16AM -0800, Kees Cook wrote:
>From: Aleksandr Yashkin <a.yashkin@inango-systems.com>
>
>[ Upstream commit 9e5f1c19800b808a37fb9815a26d382132c26c3d ]
>
>The ram_core.c routines treat przs as circular buffers. When writing a
>new crash dump, the old buffer needs to be cleared so that the new dump
>doesn't end up in the wrong place (i.e. at the end).
>
>The solution to this problem is to reset the circular buffer state before
>writing a new Oops dump.
>
>Signed-off-by: Aleksandr Yashkin <a.yashkin@inango-systems.com>
>Signed-off-by: Nikolay Merinov <n.merinov@inango-systems.com>
>Signed-off-by: Ariel Gilman <a.gilman@inango-systems.com>
>Link: https://lore.kernel.org/r/20191223133816.28155-1-n.merinov@inango-systems.com
>Fixes: 896fc1f0c4c6 ("pstore/ram: Switch to persistent_ram routines")
>[kees: backport to v4.9]
>Link: https://lore.kernel.org/stable/157831399811194@kroah.com
>Signed-off-by: Kees Cook <keescook@chromium.org>
Thanks Kees, I've queued both this and the 4.4 patch up.
--
Thanks,
Sasha
prev parent reply other threads:[~2020-01-07 18:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 18:25 [PATCH v4.9.z] pstore/ram: Write new dumps to start of recycled zones Kees Cook
2020-01-07 18:58 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107185800.GB1706@sasha-vm \
--to=sashal@kernel.org \
--cc=a.yashkin@inango-systems.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox