From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE317C282DD for ; Tue, 7 Jan 2020 21:09:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 758B32077B for ; Tue, 7 Jan 2020 21:09:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578431396; bh=Pu3pIpNS+wrWaBiCF3WMklOxbzyYKT613GwXbhqFZXE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hfDd5KCkYC3K3ELr20tZcOiPnPo3r3gG4lDKATzD+7PzmtFb9dTKZgXhWIGc7E9Fm isiqXNGfwLcP45Vpxv9TXswpbK2eL0cGQnf9FZPJLPeS5ATgRC3+6ZjLDf29jAXRPb 31EtKO+Mg/KnZyA2VRG5eYS2C2NP5Gh0YM0OiD4w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729424AbgAGVJz (ORCPT ); Tue, 7 Jan 2020 16:09:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:35924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729882AbgAGVJy (ORCPT ); Tue, 7 Jan 2020 16:09:54 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA3AF2077B; Tue, 7 Jan 2020 21:09:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578431393; bh=Pu3pIpNS+wrWaBiCF3WMklOxbzyYKT613GwXbhqFZXE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tkdi/ifFayD9+dsLln2fOFAxVNQEzxEK5BW8EyTGQoDNfhRNdSJySTCv1KuhoSw3E JZmqLNPRneWX4q3HiLflzESA+DmiU2e9yLRmR+4Pt6sW+HuBli1nyCRDz32IKel/5T UiC+olRhEnMpxisL/i4XLPKqbj4ah2dQxZXQAd6w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Linus Walleij , Russell King , Bartosz Golaszewski Subject: [PATCH 4.14 39/74] gpiolib: fix up emulated open drain outputs Date: Tue, 7 Jan 2020 21:55:04 +0100 Message-Id: <20200107205208.934980588@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200107205135.369001641@linuxfoundation.org> References: <20200107205135.369001641@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Russell King commit 256efaea1fdc4e38970489197409a26125ee0aaa upstream. gpiolib has a corner case with open drain outputs that are emulated. When such outputs are outputting a logic 1, emulation will set the hardware to input mode, which will cause gpiod_get_direction() to report that it is in input mode. This is different from the behaviour with a true open-drain output. Unify the semantics here. Cc: Suggested-by: Linus Walleij Signed-off-by: Russell King Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpiolib.c | 8 ++++++++ 1 file changed, 8 insertions(+) --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -206,6 +206,14 @@ int gpiod_get_direction(struct gpio_desc chip = gpiod_to_chip(desc); offset = gpio_chip_hwgpio(desc); + /* + * Open drain emulation using input mode may incorrectly report + * input here, fix that up. + */ + if (test_bit(FLAG_OPEN_DRAIN, &desc->flags) && + test_bit(FLAG_IS_OUT, &desc->flags)) + return 0; + if (!chip->get_direction) return status;