From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: yeyunfeng@huawei.com, rafael.j.wysocki@intel.com, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] ACPI: sysfs: Change ACPI_MASKABLE_GPE_MAX to 0x100" failed to apply to 4.14-stable tree
Date: Thu, 9 Jan 2020 13:19:30 -0500 [thread overview]
Message-ID: <20200109181930.GH1706@sasha-vm> (raw)
In-Reply-To: <1578402908237122@kroah.com>
On Tue, Jan 07, 2020 at 02:15:08PM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.14-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From a7583e72a5f22470d3e6fd3b6ba912892242339f Mon Sep 17 00:00:00 2001
>From: Yunfeng Ye <yeyunfeng@huawei.com>
>Date: Thu, 14 Nov 2019 15:16:24 +0800
>Subject: [PATCH] ACPI: sysfs: Change ACPI_MASKABLE_GPE_MAX to 0x100
>
>The commit 0f27cff8597d ("ACPI: sysfs: Make ACPI GPE mask kernel
>parameter cover all GPEs") says:
> "Use a bitmap of size 0xFF instead of a u64 for the GPE mask so 256
> GPEs can be masked"
>
>But the masking of GPE 0xFF it not supported and the check condition
>"gpe > ACPI_MASKABLE_GPE_MAX" is not valid because the type of gpe is
>u8.
>
>So modify the macro ACPI_MASKABLE_GPE_MAX to 0x100, and drop the "gpe >
>ACPI_MASKABLE_GPE_MAX" check. In addition, update the docs "Format" for
>acpi_mask_gpe parameter.
>
>Fixes: 0f27cff8597d ("ACPI: sysfs: Make ACPI GPE mask kernel parameter cover all GPEs")
>Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
>[ rjw: Use u16 as gpe data type in acpi_gpe_apply_masked_gpes() ]
>Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
We don't need this on 4.14 and older becuase they don't have
0f27cff8597d ("ACPI: sysfs: Make ACPI GPE mask kernel parameter cover
all GPEs").
--
Thanks,
Sasha
prev parent reply other threads:[~2020-01-09 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 13:15 FAILED: patch "[PATCH] ACPI: sysfs: Change ACPI_MASKABLE_GPE_MAX to 0x100" failed to apply to 4.14-stable tree gregkh
2020-01-09 18:19 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109181930.GH1706@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
--cc=yeyunfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox