From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBAFDC33CA2 for ; Fri, 10 Jan 2020 11:00:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF23F2082E for ; Fri, 10 Jan 2020 11:00:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727455AbgAJLAg (ORCPT ); Fri, 10 Jan 2020 06:00:36 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:48576 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727537AbgAJLAf (ORCPT ); Fri, 10 Jan 2020 06:00:35 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id EF8B91C25B1; Fri, 10 Jan 2020 12:00:33 +0100 (CET) Date: Fri, 10 Jan 2020 12:00:33 +0100 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Marcel Holtmann , Sasha Levin Subject: Re: [PATCH 4.19 118/219] rfkill: allocate static minor Message-ID: <20200110110033.GA11563@amd> References: <20191229162508.458551679@linuxfoundation.org> <20191229162526.353368525@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline In-Reply-To: <20191229162526.353368525@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun 2019-12-29 18:18:40, Greg Kroah-Hartman wrote: > From: Marcel Holtmann >=20 > [ Upstream commit 8670b2b8b029a6650d133486be9d2ace146fd29a ] >=20 > udev has a feature of creating /dev/ device-nodes if it finds > a devnode: modalias. This allows for auto-loading of modules that > provide the node. This requires to use a statically allocated minor > number for misc character devices. >=20 > However, rfkill uses dynamic minor numbers and prevents auto-loading > of the module. So allocate the next static misc minor number and use > it for rfkill. Is this good idea for stable? I don't see this major/minor allocated in devices.txt in mainline. Should something like this be added? Signed-off-by: Pavel Machek diff --git a/Documentation/admin-guide/devices.txt b/Documentation/admin-gu= ide/devices.txt index 1c5d2281efc9..aa888a350df8 100644 --- a/Documentation/admin-guide/devices.txt +++ b/Documentation/admin-guide/devices.txt @@ -375,8 +375,9 @@ 239 =3D /dev/uhid User-space I/O driver support for HID subsystem 240 =3D /dev/userio Serio driver testing device 241 =3D /dev/vhost-vsock Host kernel driver for virtio vsock + 242 =3D /dev/rfkill Turning off radio transmissions (rfkill) =20 - 242-254 Reserved for local use + 243-254 Reserved for local use 255 Reserved for MISC_DYNAMIC_MINOR =20 11 char Raw keyboard device (Linux/SPARC only) --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl4YWVEACgkQMOfwapXb+vKgbwCfaxl2Th8eHRr/0sPSWcX1vNAW BisAnRRhvoGsuElHI0g8boMeSvbzTo7F =66Dr -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB--