From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4318EC33C9E for ; Sat, 11 Jan 2020 10:34:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1684920678 for ; Sat, 11 Jan 2020 10:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578738874; bh=8BA9Z4C/DYOID+GlvHj2ZQFLM+aBKq46II69elxwjfo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mWLTJJbV/FhfsOhNEcIxOn77+ra4PdrqJ0fti0oJ4HKFWmvBcER74v5AuDfQ5nphp d9ybUw2VqZCOPq+ABViEXJt3AIHwgdN0kMJbsyPQrFOEiklW7iv/oz1qw10jdxdYIK 2kBUyNeaHOgrtbqSGei4ldJeA1Z7diJk9vvPEwUI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731588AbgAKKe3 (ORCPT ); Sat, 11 Jan 2020 05:34:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:50696 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731597AbgAKKe2 (ORCPT ); Sat, 11 Jan 2020 05:34:28 -0500 Received: from localhost (unknown [62.119.166.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3491420842; Sat, 11 Jan 2020 10:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578738867; bh=8BA9Z4C/DYOID+GlvHj2ZQFLM+aBKq46II69elxwjfo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gmwo0bJ0LZBy2LEIlRuyR4LrVrhWtDlo/YUmMS1p11peAOuJirYCFy5UOBUonLHhp 1Te5yW1bSc56LQTUo+9Sv/e/gFrsDrI4vTia0pzBx9tZ/XHXXWr8rr/OjIS4vRj8MG 7qdpNISYlnH5TN1JkrrKuPL5ThaAnox4h1ecA6KY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thinh Nguyen Subject: [PATCH 5.4 162/165] usb: dwc3: gadget: Fix request complete check Date: Sat, 11 Jan 2020 10:51:21 +0100 Message-Id: <20200111094943.276462561@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200111094921.347491861@linuxfoundation.org> References: <20200111094921.347491861@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Thinh Nguyen commit ea0d762775e20aaff7909a3f0866ff1688b1c618 upstream. We can only check for IN direction if the request had completed. For OUT direction, it's perfectly fine that the host can send less than the setup length. Let's return true fall all cases of OUT direction. Fixes: e0c42ce590fe ("usb: dwc3: gadget: simplify IOC handling") Cc: stable@vger.kernel.org Signed-off-by: Thinh Nguyen Link: https://lore.kernel.org/r/ac5a3593a94fdaa3d92e6352356b5f7a01ccdc7c.1576291140.git.thinhn@synopsys.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/gadget.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2467,6 +2467,13 @@ static int dwc3_gadget_ep_reclaim_trb_li static bool dwc3_gadget_ep_request_completed(struct dwc3_request *req) { + /* + * For OUT direction, host may send less than the setup + * length. Return true for all OUT requests. + */ + if (!req->direction) + return true; + return req->request.actual == req->request.length; }