From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E558C32771 for ; Wed, 15 Jan 2020 17:21:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E85662467A for ; Wed, 15 Jan 2020 17:21:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579108890; bh=lj6dG1jiiZtm+t3uE76M72ECvRumXwWAIZv2H54jjK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=UgEOKX0EIR6pDGQxRM+eXqYOfTURbQd22HMAsWBBiuJDvzGumE7F7nGgFSvqppJw0 zaLv/m7MtwmfiUdCYdvC12rl/ubLgyzxmEfcL7Yg/xYOGVlQQMDYbe7weuSPtmXptV GBiw1mV05dtmsuIt8KahLUMRVs8jSy3YGqS/V9dI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728982AbgAORV3 (ORCPT ); Wed, 15 Jan 2020 12:21:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:49424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727016AbgAORV3 (ORCPT ); Wed, 15 Jan 2020 12:21:29 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3749E24671; Wed, 15 Jan 2020 17:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579108888; bh=lj6dG1jiiZtm+t3uE76M72ECvRumXwWAIZv2H54jjK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R6J4aYn55KVaZr35ao7n9TIQJ5A1K5+ihjd00AuNkdY4zS1MoNMNZebFB9XuJRg7I 9lixIXV5Li8Eb/7KCQIFOIiShLSFTYSN/WWfAvMztOxEGB4/3OPj0Gy/PzKnpuQ10d 8pe7kkrhK4U8fCObDw2gFZrnioGxXw7+Yl6jVZyk= Date: Wed, 15 Jan 2020 18:21:26 +0100 From: Greg KH To: Suzuki Kuruppassery Poulose Cc: Sasha Levin , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [stable] [PATCH 1/2] coresight: etb10: Do not call smp_processor_id from preemptible Message-ID: <20200115172126.GB4127163@kroah.com> References: <20200108110541.318672-1-suzuki.poulose@arm.com> <20200109143537.GE1706@sasha-vm> <20200115151118.GC3740793@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jan 15, 2020 at 04:44:29PM +0000, Suzuki Kuruppassery Poulose wrote: > > Hi Greg, > > On 15/01/2020 15:11, Greg KH wrote: > > On Thu, Jan 09, 2020 at 02:36:17PM +0000, Suzuki Kuruppassery Poulose wrote: > > > On 09/01/2020 14:35, Sasha Levin wrote: > > > > On Wed, Jan 08, 2020 at 11:05:40AM +0000, Suzuki K Poulose wrote: > > > > > [ Upstream commit 730766bae3280a25d40ea76a53dc6342e84e6513 ] > > > > > > > > > > During a perf session we try to allocate buffers on the "node" associated > > > > > with the CPU the event is bound to. If it is not bound to a CPU, we > > > > > use the current CPU node, using smp_processor_id(). However this is > > > > > unsafe > > > > > in a pre-emptible context and could generate the splats as below : > > > > > > > > > > BUG: using smp_processor_id() in preemptible [00000000] code: perf/2544 > > > > > > > > > > Use NUMA_NO_NODE hint instead of using the current node for events > > > > > not bound to CPUs. > > > > > > > > > > Fixes: 2997aa4063d97fdb39 ("coresight: etb10: implementing AUX API") > > > > > Cc: Mathieu Poirier > > > > > Signed-off-by: Suzuki K Poulose > > > > > Cc: stable # v4.9 to v4.19 > > > > > Signed-off-by: Mathieu Poirier > > > > > Link: https://lore.kernel.org/r/20190620221237.3536-5-mathieu.poirier@linaro.org > > > > > > > > > > > > > I've queued this for 4.9-4.19. There was a simple conflict on 4.9 which > > > > also had to be resolved. > > > > > > > > > > > > > Thanks Sasha ! > > > > Note, these had to all be dropped as they broke the build :( > > > > So can you please send us patches that at least build? :) > > > > Do you have a build failure log ? I did build test it before sending it > over. I tried it again on 4.9, 4.14 and 4.19. I don't hit any build > failures here. > > Please could you share the log if you have it handy ? It was in the stable -rc review emails, I don't have it handy, sorry. greg k-h