From: Kees Cook <keescook@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, Sami Tolvanen <samitolvanen@google.com>
Subject: Re: missing backports for x86 syscall function prototype cleanups
Date: Thu, 16 Jan 2020 15:53:45 -0800 [thread overview]
Message-ID: <202001161553.F3FD9E9@keescook> (raw)
In-Reply-To: <20200116082848.GA2359@kroah.com>
On Thu, Jan 16, 2020 at 09:28:48AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 15, 2020 at 05:41:07PM -0800, Kees Cook wrote:
> > Hi!
> >
> > Sami pointed out to me that 4 of 6 patches in Linus's tree that were
> > cleaning up the x86 syscall function prototypes didn't make it into
> > -stable.
> >
> > These were backported:
> >
> > 8661d769ab77 ("syscalls/x86: Use the correct function type in SYSCALL_DEFINE0")
> > (as e79138ba8e0ec84f3ab5daa4761e4d534bbc682d)
> > f53e2cd0b8ab ("x86/mm: Use the correct function type for native_set_fixmap()")
> > (as a823d762a57519adeb33f5f12f761d636e42d32e)
> >
> > But these are missing, leading to some confusion when working with v5.4
> > under CFI:
> >
> > cf3b83e19d7c928e05a5d193c375463182c6029a
> > 00198a6eaf66609de5e4de9163bb42c7ca9dd7b7
> > f48f01a92cca09e86d46c91d8edf9d5a71c61727
> > 6e4847640c6aebcaa2d9b3686cecc91b41f09269
> >
> > Can these get added please?
>
> I've queued them up now. But for 4.19, are these also needed? If so,
> f48f01a92cca ("syscalls/x86: Use the correct function type for
> sys_ni_syscall") needs a backport for it to work properly.
I think, for now, we don't need to. v5.4 should be enough. Thanks!
-Kees
--
Kees Cook
prev parent reply other threads:[~2020-01-16 23:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 1:41 missing backports for x86 syscall function prototype cleanups Kees Cook
2020-01-16 8:28 ` Greg Kroah-Hartman
2020-01-16 23:53 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001161553.F3FD9E9@keescook \
--to=keescook@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=samitolvanen@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox