From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B94B6C33CAF for ; Thu, 16 Jan 2020 19:14:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BE822075B for ; Thu, 16 Jan 2020 19:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579202071; bh=EVK8+bMUW7+5NJwclqnG4oQpje6rvaXknNBN5JRwWNY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bTh4s+od85SU2OplDRd9cMYqEnYzm3I8S49ozoicsm4sMrjh8KlpS31b088vM5ZZ8 8MGcxZL/iWMbmbAP3BqM/1dipholZl5Je1L1YDCsmIbEmd1P1d9JO0d0OlScZNQu3V 8BAacv6/8prDTa36FXyZB0lwKL5teDCV5cD+URgs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387524AbgAPTO2 (ORCPT ); Thu, 16 Jan 2020 14:14:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:42780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733241AbgAPQ42 (ORCPT ); Thu, 16 Jan 2020 11:56:28 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 428EB20730; Thu, 16 Jan 2020 16:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193788; bh=EVK8+bMUW7+5NJwclqnG4oQpje6rvaXknNBN5JRwWNY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=abUxfRduBk7SB4/x3lNPU/NxN2ukO7IUtqZKd1WpQgMw1oxCXzKq6lzYa41rstK/y bWmCsaXBf2Qi3fGgxBaGjlExudHWlyUrj3+5NQk+DH7UqHvYVybFbYgY3CZ6jjBaAY xyA1AOKuLbCGolt3OlWJD3Hr8/0ZISYxdvzfHtWo= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Nishanth Menon , Jassi Brar , Sasha Levin Subject: [PATCH AUTOSEL 4.19 063/671] mailbox: ti-msgmgr: Off by one in ti_msgmgr_of_xlate() Date: Thu, 16 Jan 2020 11:44:54 -0500 Message-Id: <20200116165502.8838-63-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116165502.8838-1-sashal@kernel.org> References: <20200116165502.8838-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit 78f3ff524fca63e7d2a57149a34ade23d2c12798 ] The > comparison should be >= or we access one element beyond the end of the array. (The inst->qinsts[] array is allocated in the ti_msgmgr_probe() function and it has ->num_valid_queues elements.) Fixes: a2b79838b891 ("mailbox: ti-msgmgr: Add support for Secure Proxy") Signed-off-by: Dan Carpenter Acked-by: Nishanth Menon Signed-off-by: Jassi Brar Signed-off-by: Sasha Levin --- drivers/mailbox/ti-msgmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/ti-msgmgr.c b/drivers/mailbox/ti-msgmgr.c index 5bceafbf6699..01e9e462512b 100644 --- a/drivers/mailbox/ti-msgmgr.c +++ b/drivers/mailbox/ti-msgmgr.c @@ -547,7 +547,7 @@ static struct mbox_chan *ti_msgmgr_of_xlate(struct mbox_controller *mbox, } if (d->is_sproxy) { - if (req_pid > d->num_valid_queues) + if (req_pid >= d->num_valid_queues) goto err; qinst = &inst->qinsts[req_pid]; return qinst->chan; -- 2.20.1