From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DD59C33CB6 for ; Thu, 16 Jan 2020 17:46:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CFF5246DC for ; Thu, 16 Jan 2020 17:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196773; bh=6D+79WwMSPJwWxIogyrPAlZXVQVa57CQ2ordv16TGEA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WmbixziF1fcEbpZRC7IKd2RDCxjT6xOftru1LadjT7D8CN13FK8OUpIdx+OO2DaD6 bGcJnDqv9C6bLDu5XkfUd5xfnt/1PAid5jhxKLnazQGDa2CCM8qnY/zGF5kLtfvFSE ZPpxKk1WVpRYib9OFJZXu75T1BTTy9FDGfSNZoHw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406585AbgAPRqM (ORCPT ); Thu, 16 Jan 2020 12:46:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:38682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405934AbgAPRqL (ORCPT ); Thu, 16 Jan 2020 12:46:11 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0EDED246D9; Thu, 16 Jan 2020 17:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196771; bh=6D+79WwMSPJwWxIogyrPAlZXVQVa57CQ2ordv16TGEA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e6WHy6lMy7h0EeLvS6oRzojwXtX41fZXP98P4QCyR5Nhi355H+7UC7L/mgCvVerWU yZ31IqOoZctnXf/EJ8aP5jb+QxcZWdChdz4K4pmQb+DyaqSuLMsDdZkVmg93S1MPWz y8qTdEjB2UJEw73/xXwPEuemFqEtuorHCsEHG3ms= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 4.4 142/174] net: ethernet: stmmac: Fix signedness bug in ipq806x_gmac_of_parse() Date: Thu, 16 Jan 2020 12:42:19 -0500 Message-Id: <20200116174251.24326-142-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116174251.24326-1-sashal@kernel.org> References: <20200116174251.24326-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit 231042181dc9d6122c6faba64e99ccb25f13cc6c ] The "gmac->phy_mode" variable is an enum and in this context GCC will treat it as an unsigned int so the error handling will never be triggered. Fixes: b1c17215d718 ("stmmac: add ipq806x glue layer") Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c index 82de68b1a452..1fc356c17750 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c @@ -203,7 +203,7 @@ static void *ipq806x_gmac_of_parse(struct ipq806x_gmac *gmac) struct device *dev = &gmac->pdev->dev; gmac->phy_mode = of_get_phy_mode(dev->of_node); - if (gmac->phy_mode < 0) { + if ((int)gmac->phy_mode < 0) { dev_err(dev, "missing phy mode property\n"); return ERR_PTR(-EINVAL); } -- 2.20.1