From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCC58C33CB7 for ; Thu, 16 Jan 2020 17:59:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8EE4246B4 for ; Thu, 16 Jan 2020 17:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579197588; bh=tBxxBgzuVF3cyv3BM1111FtWx8q4jyNNc4Fa0k9fg6o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=O6o4wuOiJBhFOL20urcbZRTHW8CPrwOqdiTQeNLru4uV1rec1NfWmvgTj9NoL+6PI JqvYobqu8fY5KJht5u5v7BZwPHd2bnbhTT2oqYwAvqUKkhpqYKvlurZoHK7oG2gjBn lN1bLjWM2cFdhh1iFBcWE1z59GOPrj3EcD1LRssc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730338AbgAPR7r (ORCPT ); Thu, 16 Jan 2020 12:59:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:32778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405858AbgAPRm4 (ORCPT ); Thu, 16 Jan 2020 12:42:56 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 48097246A4; Thu, 16 Jan 2020 17:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196576; bh=tBxxBgzuVF3cyv3BM1111FtWx8q4jyNNc4Fa0k9fg6o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uC/95qMfE7NpQCrQbtYzMMrGugo4esOnu/eJvJndWOJnup5G3PnnwqOobAJZahZRa 6WZZUPKYEkj2uy+SXVZ9otZ/Ynv0CWXobGtGdWcMgH0MRAJJsimIZL5EbxnNEpHcYF T/5f2GgSaUiJr0QIIbQRo5DShrjsxnV8SA4irkw0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Linus Walleij , Leonard Crestez , Fabio Estevam , John Stultz , Anders Roxell , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL 4.4 003/174] regulator: fixed: Default enable high on DT regulators Date: Thu, 16 Jan 2020 12:40:00 -0500 Message-Id: <20200116174251.24326-3-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116174251.24326-1-sashal@kernel.org> References: <20200116174251.24326-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Linus Walleij [ Upstream commit 28be5f15df2ee6882b0a122693159c96a28203c7 ] commit efdfeb079cc3 ("regulator: fixed: Convert to use GPIO descriptor only") switched to use gpiod_get() to look up the regulator from the gpiolib core whether that is device tree or boardfile. This meant that we activate the code in a603a2b8d86e ("gpio: of: Add special quirk to parse regulator flags") which means the descriptors coming from the device tree already have the right inversion and open drain semantics set up from the gpiolib core. As the fixed regulator was inspected again we got the inverted inversion and things broke. Fix it by ignoring the config in the device tree for now: the later patches in the series will push all inversion handling over to the gpiolib core and set it up properly in the boardfiles for legacy devices, but I did not finish that for this kernel cycle. Fixes: commit efdfeb079cc3 ("regulator: fixed: Convert to use GPIO descriptor only") Reported-by: Leonard Crestez Reported-by: Fabio Estevam Reported-by: John Stultz Reported-by: Anders Roxell Signed-off-by: Linus Walleij Tested-by: John Stultz Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/fixed.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c index ff62d69ba0be..24ad5e6832df 100644 --- a/drivers/regulator/fixed.c +++ b/drivers/regulator/fixed.c @@ -94,9 +94,14 @@ of_get_fixed_voltage_config(struct device *dev, of_property_read_u32(np, "startup-delay-us", &config->startup_delay); - config->enable_high = of_property_read_bool(np, "enable-active-high"); - config->gpio_is_open_drain = of_property_read_bool(np, - "gpio-open-drain"); + /* + * FIXME: we pulled active low/high and open drain handling into + * gpiolib so it will be handled there. Delete this in the second + * step when we also remove the custom inversion handling for all + * legacy boardfiles. + */ + config->enable_high = 1; + config->gpio_is_open_drain = 0; if (of_find_property(np, "vin-supply", NULL)) config->input_supply = "vin"; -- 2.20.1