From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 716D8C33CAF for ; Thu, 16 Jan 2020 23:43:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A0062064C for ; Thu, 16 Jan 2020 23:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579218198; bh=77/Gy00sz07sYUnF0AlWCXpY0U9NWEAYrzKzK1mqUzg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RYOidrnilKVsUQWit5+4SgyTc53d+JeObHSWQR0L5Oh52mtr4BvPVbnF4tEfislor zpZQjVFzPt1mBa/JYICtZj8dW/SZNkKiLgNbLx1PIUD8mEtH0baBJg0s0lA9UD8Bab +EZkcGGGeLoVXMTfmlfYVyTgkujixslEPGLT/9Z8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388682AbgAPXZk (ORCPT ); Thu, 16 Jan 2020 18:25:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:55432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731718AbgAPXZk (ORCPT ); Thu, 16 Jan 2020 18:25:40 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3635920684; Thu, 16 Jan 2020 23:25:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217139; bh=77/Gy00sz07sYUnF0AlWCXpY0U9NWEAYrzKzK1mqUzg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zHOG7bcNHcSp34XnlNTdeiu9EhcKbjrL51y5XPjPER9NX3nf7egatDjfG5j48MA56 R2cA2+sdU7ttTOsVOw3sfUmB7EOCUvRLgLzoRhGn2Lgv9vkcfL7U/34y5CB77PgmkL 2nwfBSRjKdFZvkAVuEd9OGmrN6GbrV809RLXHIP8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hewenliang , Lorenzo Pieralisi , Kishon Vijay Abraham I Subject: [PATCH 5.4 137/203] tools: PCI: Fix fd leakage Date: Fri, 17 Jan 2020 00:17:34 +0100 Message-Id: <20200116231757.024280725@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200116231745.218684830@linuxfoundation.org> References: <20200116231745.218684830@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Hewenliang commit 3c379a59b4795d7279d38c623e74b9790345a32b upstream. We should close fd before the return of run_test. Fixes: 3f2ed8134834 ("tools: PCI: Add a userspace tool to test PCI endpoint") Signed-off-by: Hewenliang Signed-off-by: Lorenzo Pieralisi Acked-by: Kishon Vijay Abraham I Signed-off-by: Greg Kroah-Hartman --- tools/pci/pcitest.c | 1 + 1 file changed, 1 insertion(+) --- a/tools/pci/pcitest.c +++ b/tools/pci/pcitest.c @@ -129,6 +129,7 @@ static int run_test(struct pci_test *tes } fflush(stdout); + close(fd); return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */ }