From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E2EAC33CAF for ; Thu, 16 Jan 2020 23:43:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF2452073A for ; Thu, 16 Jan 2020 23:43:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579218195; bh=lkSHes5e9d4xcqebKv/yK6/bBAOg+pa91rHSqGY9AQg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=z0jTtzHmwX3NYen87DcXV/I5/+3ZaGFqdnU+8G8USswT9uW77d6T/TzFPz4FsJLs2 nSmsC07pKGQG34Smni45tVdtse6B6+WouQM2atCvUpOUIlha41tvpPPPFrMqksn2ux 76SChHq5flSYTr5307XCf32fqCBHo9tvSU5sNUTA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388971AbgAPXnL (ORCPT ); Thu, 16 Jan 2020 18:43:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:55668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389006AbgAPXZr (ORCPT ); Thu, 16 Jan 2020 18:25:47 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7819D20684; Thu, 16 Jan 2020 23:25:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217146; bh=lkSHes5e9d4xcqebKv/yK6/bBAOg+pa91rHSqGY9AQg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cIuZ2WKEp/4I8IyB/Dq+AVTsCmMOo8odybWwQIKFqZ4LkKm46Icbq+ZXgyWmP7soc 5NsWEEKnvLR4P7nrMmRnK6R78bkp8JsjYLw47Vy4dKLiH555kv0HfIOkrn1QTZKjRo +TYVTrsky9mG/+v3I8oLVY7tGBVP6X+Xcbro+dqo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sergei Shtylyov , Tudor Ambarus Subject: [PATCH 5.4 167/203] mtd: spi-nor: fix silent truncation in spi_nor_read_raw() Date: Fri, 17 Jan 2020 00:18:04 +0100 Message-Id: <20200116231759.221421726@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200116231745.218684830@linuxfoundation.org> References: <20200116231745.218684830@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Sergei Shtylyov commit 3d63ee5deb466fd66ed6ffb164a87ce36425cf36 upstream. spi_nor_read_raw() assigns the result of 'ssize_t spi_nor_read_data()' to the 'int ret' variable, while 'ssize_t' is a 64-bit type and *int* is a 32-bit type on the 64-bit machines. This silent truncation isn't really valid, so fix up the variable's type. Fixes: f384b352cbf0 ("mtd: spi-nor: parse Serial Flash Discoverable Parameters (SFDP) tables") Signed-off-by: Sergei Shtylyov Signed-off-by: Tudor Ambarus Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/spi-nor/spi-nor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -2865,7 +2865,7 @@ static int spi_nor_hwcaps_pp2cmd(u32 hwc */ static int spi_nor_read_raw(struct spi_nor *nor, u32 addr, size_t len, u8 *buf) { - int ret; + ssize_t ret; while (len) { ret = spi_nor_read_data(nor, addr, len, buf);