From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BAFFC33CB1 for ; Sun, 19 Jan 2020 16:36:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2947320684 for ; Sun, 19 Jan 2020 16:36:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579451799; bh=/bx+yN8jpdYywV4f+8wcmgyIsGt1frYX136HUJoVIa0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=r45kWg/1Hn86odwPyqoBe9xsdq9TvlZp5fBBAECH17bWu5mLJY0/KKVsovMkFpfSN Eoz1X02zQvKH1saAgNZLMg4d1lIA+70Alme4hi05EzuBK1HL1NYsUrAuK+mL0Fi1YF BGg+Y/ncGh27CguECTXtCB344bo3u7J5jbeoz5go= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726925AbgASQgi (ORCPT ); Sun, 19 Jan 2020 11:36:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:33960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726860AbgASQgi (ORCPT ); Sun, 19 Jan 2020 11:36:38 -0500 Received: from localhost (96-81-74-198-static.hfc.comcastbusiness.net [96.81.74.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A720720679; Sun, 19 Jan 2020 16:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579451797; bh=/bx+yN8jpdYywV4f+8wcmgyIsGt1frYX136HUJoVIa0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AIkCSJcZUwzjDHryMOhZ02Q5eIuAD8hCiWxnCYL1IuXirc6P2zHSEDAnG+fDGwCQY KHViFD1zPG5uDNNoBL25Qa+oaBb5+hrf2F3Xlz/CTQWMQz1KoSxUX3q05gi7HConYW GIU9kULURMtoyvLTtnKmJPekd4KkN7Mr5XvtXMek= Date: Sun, 19 Jan 2020 11:36:35 -0500 From: Sasha Levin To: gregkh@linuxfoundation.org Cc: arnd@arndb.de, jkosina@suse.cz, tglx@linutronix.de, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] cpu/SMT: Fix x86 link error without CONFIG_SYSFS" failed to apply to 4.19-stable tree Message-ID: <20200119163635.GU1706@sasha-vm> References: <1579444808186154@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1579444808186154@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sun, Jan 19, 2020 at 03:40:08PM +0100, gregkh@linuxfoundation.org wrote: > >The patch below does not apply to the 4.19-stable tree. >If someone wants it applied there, or to any other stable or longterm >tree, then please email the backport, including the original git commit >id to . > >thanks, > >greg k-h > >------------------ original commit in Linus's tree ------------------ > >>From dc8d37ed304eeeea47e65fb9edc1c6c8b0093386 Mon Sep 17 00:00:00 2001 >From: Arnd Bergmann >Date: Tue, 10 Dec 2019 20:56:04 +0100 >Subject: [PATCH] cpu/SMT: Fix x86 link error without CONFIG_SYSFS > >When CONFIG_SYSFS is disabled, but CONFIG_HOTPLUG_SMT is enabled, >the kernel fails to link: > >arch/x86/power/cpu.o: In function `hibernate_resume_nonboot_cpu_disable': >(.text+0x38d): undefined reference to `cpuhp_smt_enable' >arch/x86/power/hibernate.o: In function `arch_resume_nosmt': >hibernate.c:(.text+0x291): undefined reference to `cpuhp_smt_enable' >hibernate.c:(.text+0x29c): undefined reference to `cpuhp_smt_disable' > >Move the exported functions out of the #ifdef section into its >own with the correct conditions. > >The patch that caused this is marked for stable backports, so >this one may need to be backported as well. > >Fixes: ec527c318036 ("x86/power: Fix 'nosmt' vs hibernation triple fault during resume") >Signed-off-by: Arnd Bergmann >Signed-off-by: Thomas Gleixner >Reviewed-by: Jiri Kosina >Cc: stable@vger.kernel.org >Link: https://lore.kernel.org/r/20191210195614.786555-1-arnd@arndb.de I'm not actually seeing this failure on 4.19 and older, so I won't try and figure this out. $ grep 'CONFIG_HOTPLUG_SMT\|CONFIG_SYSFS' .config # CONFIG_SYSFS_SYSCALL is not set CONFIG_HOTPLUG_SMT=y # CONFIG_SYSFS is not set $ make -j [...] Kernel: arch/x86/boot/bzImage is ready (#1) -- Thanks, Sasha