From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C29E3C33CAF for ; Sun, 19 Jan 2020 18:53:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9881620679 for ; Sun, 19 Jan 2020 18:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579460011; bh=g54lcafQeBdaVWsOI3myQqqk/Q/dyMCJvoQVweioQYI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=JCsCNJWesZ8KmvArCnZyQYmmY/S4Aw1ac0l5DuXjugqOBfYicxGipRpBaRRcYeTVX 4nb7raMAKfa70LyDPJjeY2rP5urY6lObccTInUFnkrTJHeTlRxvTDl1yKesq/lHEv1 BRgng+XvAUKd6IcSWhPBvyOpetPP7fvRBIHiiugM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727138AbgASSxb (ORCPT ); Sun, 19 Jan 2020 13:53:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:57082 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727123AbgASSxa (ORCPT ); Sun, 19 Jan 2020 13:53:30 -0500 Received: from localhost (96-81-74-198-static.hfc.comcastbusiness.net [96.81.74.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D77320679; Sun, 19 Jan 2020 18:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579460010; bh=g54lcafQeBdaVWsOI3myQqqk/Q/dyMCJvoQVweioQYI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K59+gbrCvo80P5lh+L+HzZx6lMzWdgL9bwQfeVkxUve5sf755LE2qy4/JW7dziCXU nWWmGD3NlxIo7aSACCHlaMWqTYN5NREU6vjyursXawhR3gX9VHf81pGCtujcrSsWIe Yeyu1perivdP+zG6zQMKtCufyYPPZ0WtSdED72XU= Date: Sun, 19 Jan 2020 13:53:26 -0500 From: Sasha Levin To: Johan Hovold Cc: gregkh@linuxfoundation.org, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] USB: serial: keyspan: handle unbound ports" failed to apply to 4.9-stable tree Message-ID: <20200119185326.GW1706@sasha-vm> References: <157944127621242@kroah.com> <20200119154733.GR1706@sasha-vm> <20200119160136.GB2301@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200119160136.GB2301@localhost> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sun, Jan 19, 2020 at 05:01:36PM +0100, Johan Hovold wrote: >On Sun, Jan 19, 2020 at 10:47:33AM -0500, Sasha Levin wrote: >> On Sun, Jan 19, 2020 at 02:41:16PM +0100, gregkh@linuxfoundation.org wrote: >> > >> >The patch below does not apply to the 4.9-stable tree. >> >If someone wants it applied there, or to any other stable or longterm >> >tree, then please email the backport, including the original git commit >> >id to . >> > >> >thanks, >> > >> >greg k-h >> > >> >------------------ original commit in Linus's tree ------------------ >> > >> >From 3018dd3fa114b13261e9599ddb5656ef97a1fa17 Mon Sep 17 00:00:00 2001 >> >From: Johan Hovold >> >Date: Fri, 17 Jan 2020 10:50:25 +0100 >> >Subject: [PATCH] USB: serial: keyspan: handle unbound ports >> > >> >Check for NULL port data in the control URB completion handlers to avoid >> >dereferencing a NULL pointer in the unlikely case where a port device >> >isn't bound to a driver (e.g. after an allocation failure on port >> >probe()). >> > >> >Fixes: 0ca1268e109a ("USB Serial Keyspan: add support for USA-49WG & USA-28XG") >> >Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") >> >Cc: stable >> >Reviewed-by: Greg Kroah-Hartman >> >Signed-off-by: Johan Hovold >> >> Grabbing the prerequisite for the other USB patch also resolved the >> conflict here, now queued for 4.9 and 4.4. > >Just curious; which prerequisite are referring to here? I can't seem to >understand why this one failed to apply to 4.9 in the first place as >there hasn't really been any changes to that code in the keyspan driver. I thought that it was either dd1fae527612 ("USB: serial: io_edgeport: use irqsave() in USB's complete callback") or the stable commit that was applied on top, but you're right - it doesn't seem to be either of those. -- Thanks, Sasha