From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CC34C33CB8 for ; Wed, 22 Jan 2020 09:47:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 497CB2467C for ; Wed, 22 Jan 2020 09:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579686450; bh=0oF3uSLp7so0kjfvcUBglP4VRwZLRZ+56HRBZYyOKKs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=QE7k/sj0wZKxka1v+SSy6O/ZHjFUs9zJBnp4ALosnIAt6FoeDrpXy7d/xAcaTlUie BeVEjzx72yQbzKw9DRYliXBq3bA2xkY6epii9fO/GV5dgcl8aspYWAPAou7dQywuui ehphF7ndK8C1slUfXuZqUvLdH/psC8vSEIhtxXuA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387529AbgAVJmP (ORCPT ); Wed, 22 Jan 2020 04:42:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:33956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387689AbgAVJmO (ORCPT ); Wed, 22 Jan 2020 04:42:14 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4261624680; Wed, 22 Jan 2020 09:42:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579686133; bh=0oF3uSLp7so0kjfvcUBglP4VRwZLRZ+56HRBZYyOKKs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TBvC349hFi/kvZozUrxlCDGwqHGGJPtLw0j50At9nRFf1CiPYwJBOd38QmYf8xDg5 CyaM2SDx6sQD2eNHQkNlTfhsLsl/OAFK1SwUq3MdOCtsVDRH1zj1S2pqSrn+0EkaGI aUbbqS1XWBLz1+WEWzrDGD3NrqydsWL8GoDh0rZs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Markus Theil , Johannes Berg Subject: [PATCH 4.19 056/103] cfg80211: fix deadlocks in autodisconnect work Date: Wed, 22 Jan 2020 10:29:12 +0100 Message-Id: <20200122092812.073866895@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200122092803.587683021@linuxfoundation.org> References: <20200122092803.587683021@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Markus Theil commit 5a128a088a2ab0b5190eeb232b5aa0b1017a0317 upstream. Use methods which do not try to acquire the wdev lock themselves. Cc: stable@vger.kernel.org Fixes: 37b1c004685a3 ("cfg80211: Support all iftypes in autodisconnect_wk") Signed-off-by: Markus Theil Link: https://lore.kernel.org/r/20200108115536.2262-1-markus.theil@tu-ilmenau.de Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- net/wireless/sme.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/net/wireless/sme.c +++ b/net/wireless/sme.c @@ -1281,14 +1281,14 @@ void cfg80211_autodisconnect_wk(struct w if (wdev->conn_owner_nlportid) { switch (wdev->iftype) { case NL80211_IFTYPE_ADHOC: - cfg80211_leave_ibss(rdev, wdev->netdev, false); + __cfg80211_leave_ibss(rdev, wdev->netdev, false); break; case NL80211_IFTYPE_AP: case NL80211_IFTYPE_P2P_GO: - cfg80211_stop_ap(rdev, wdev->netdev, false); + __cfg80211_stop_ap(rdev, wdev->netdev, false); break; case NL80211_IFTYPE_MESH_POINT: - cfg80211_leave_mesh(rdev, wdev->netdev); + __cfg80211_leave_mesh(rdev, wdev->netdev); break; case NL80211_IFTYPE_STATION: case NL80211_IFTYPE_P2P_CLIENT: