From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F70BC32771 for ; Fri, 24 Jan 2020 09:43:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E941E222D9 for ; Fri, 24 Jan 2020 09:43:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859013; bh=KubTyEQ8SPcUwxUOen7YwkGeLcsrd4qtAlJhpT2dbxg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mYZqzkOWavSwLp+LHkNQ0PJthXkO+AFuAh9L9DcADCwALcKqSnFWyqO/3BTlpoTit TwGKsdAzMTEGxUQeYyZczbolNHFWhsdE5mwutp1mDv4nJyhQoNS26Ck4yB4MOhWw46 Yu2ZEzyI6eN74E4UgKHmPhMfafh5K0FyTh01w3ko= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732431AbgAXJnc (ORCPT ); Fri, 24 Jan 2020 04:43:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:41530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730313AbgAXJna (ORCPT ); Fri, 24 Jan 2020 04:43:30 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A50821556; Fri, 24 Jan 2020 09:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859009; bh=KubTyEQ8SPcUwxUOen7YwkGeLcsrd4qtAlJhpT2dbxg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=okg2qRcjxYH2g5WZ1xY6gC3MQHNP4zlYvFFyR5VX7BxBdYIHSOkrvWVYj6E+cFjVU 9OD1hN7+qRBBBOZo0t6at5mejlm4s+Z4R994pV7N7v8t+MCPfW0iELg4TmGcQkFExj wVHv5UCOWk73ckIuUZj+yxx4z8qaZgcrxHPVGGXs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Maxime Ripard , Giulio Benetti , Sasha Levin Subject: [PATCH 4.14 021/343] drm/sun4i: hdmi: Fix double flag assignation Date: Fri, 24 Jan 2020 10:27:19 +0100 Message-Id: <20200124092922.389874240@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Maxime Ripard [ Upstream commit 1e0ff648940e603cab6c52cf3723017d30d78f30 ] The is_double flag is a boolean currently assigned to the value of the d variable, that is either 1 or 2. It means that this is_double variable is always set to true, even though the initial intent was to have it set to true when d is 2. Fix this. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Reported-by: Dan Carpenter Signed-off-by: Maxime Ripard Reviewed-by: Giulio Benetti Link: https://patchwork.freedesktop.org/patch/msgid/20181021163446.29135-2-maxime.ripard@bootlin.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c index 5cf2527bffc86..d7a8fea945574 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c @@ -50,7 +50,7 @@ static unsigned long sun4i_tmds_calc_divider(unsigned long rate, (rate - tmp_rate) < (rate - best_rate)) { best_rate = tmp_rate; best_m = m; - is_double = d; + is_double = (d == 2) ? true : false; } } } -- 2.20.1