From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12352C2D0DB for ; Fri, 24 Jan 2020 09:46:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB54F21556 for ; Fri, 24 Jan 2020 09:46:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859170; bh=alnITvoaT/S+HF+A2nMwqwF3MdOxhC+4VAb+/JbW5U8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ub6yo4xpdfHxKNExw/hSytlvSLQrbOuYB29Xo06/nOpjKjApn5WFJePdfHzSICtPc WZPdAkD7o4jVGQaKVdr4swb0RtOJQD9b9rr4sOwOdARU4kSRrDZmi7nCuu8zSMp/n5 ++DQB5mX2c6uw/7m7/dNAV4YFBAvisuFTwGAWvxw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732137AbgAXJp7 (ORCPT ); Fri, 24 Jan 2020 04:45:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:45114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731795AbgAXJp7 (ORCPT ); Fri, 24 Jan 2020 04:45:59 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D90320718; Fri, 24 Jan 2020 09:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859158; bh=alnITvoaT/S+HF+A2nMwqwF3MdOxhC+4VAb+/JbW5U8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zkJ2d+0mWlQiTUk2f/jp/KufnYSEGkio6tXZE2Gtc+f1J+ydaQ8XCWkm6PsDhm4ki 99VGpee43PdT44Uuf6gqliQfgkvbSfacGSfgrfsUMNVdE7lzafwxvTNYr0kz/50DnS BlsaZgj+YgbUEd0TGI4GJBdMuqwVRckrqGJNSRT4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yangtao Li , Stephen Boyd , Sasha Levin Subject: [PATCH 4.14 043/343] clk: highbank: fix refcount leak in hb_clk_init() Date: Fri, 24 Jan 2020 10:27:41 +0100 Message-Id: <20200124092925.447251202@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yangtao Li [ Upstream commit 5eb8ba90958de1285120dae5d3a5d2b1a360b3b4 ] The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount. Signed-off-by: Yangtao Li Fixes: 26cae166cff9 ("ARM: highbank: remove custom .init_time hook") Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/clk-highbank.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/clk-highbank.c b/drivers/clk/clk-highbank.c index 727ed8e1bb726..8e4581004695c 100644 --- a/drivers/clk/clk-highbank.c +++ b/drivers/clk/clk-highbank.c @@ -293,6 +293,7 @@ static __init struct clk *hb_clk_init(struct device_node *node, const struct clk /* Map system registers */ srnp = of_find_compatible_node(NULL, NULL, "calxeda,hb-sregs"); hb_clk->reg = of_iomap(srnp, 0); + of_node_put(srnp); BUG_ON(!hb_clk->reg); hb_clk->reg += reg; -- 2.20.1