From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D884C35242 for ; Fri, 24 Jan 2020 09:47:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42A19206D5 for ; Fri, 24 Jan 2020 09:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859255; bh=8d1nX4LAdMKqvkj0dwYAfO3ahLDhbe83T0nZz4dS5sQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=UxbStMHCmzleb1wumTgJt4UTlCv/+PsMhhWj8uSmrvpUO6YUA62qN4exayMD9q2iU C29nPvorF5Mugu9QHFlTI3zTmLJCVr744lhPCqVz4aejM7VRkExnKhMyUWuGR7jCRn d7QF0s3h8MEKZPgTkWxF3lJrWR6J8qIvddxpT9As= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387523AbgAXJre (ORCPT ); Fri, 24 Jan 2020 04:47:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:47368 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387394AbgAXJrd (ORCPT ); Fri, 24 Jan 2020 04:47:33 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4BCD120718; Fri, 24 Jan 2020 09:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859253; bh=8d1nX4LAdMKqvkj0dwYAfO3ahLDhbe83T0nZz4dS5sQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TxZCGtDlgDvlVou0e2WKgZMBNXYvm1kqNcCnOxuyjqQrVgHvmzg5no9ZIrNsbhjfs 1yTbamOn+0XP3yC3DmiJ/L9Li+5S831r/5HXS2NKCzqMXWtwvG4+/XtDLa5HQy8jK9 +CTtQt5T+pdDCwAkBZNIhtlH7ib80zF82QudzZyM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yangtao Li , Gregory CLEMENT , Stephen Boyd , Sasha Levin Subject: [PATCH 4.14 054/343] clk: mv98dx3236: fix refcount leak in mv98dx3236_clk_init() Date: Fri, 24 Jan 2020 10:27:52 +0100 Message-Id: <20200124092926.856809475@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yangtao Li [ Upstream commit 9b4eedf627045ae5ddcff60a484200cdd554c413 ] The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount. Signed-off-by: Yangtao Li Reviewed-by: Gregory CLEMENT Fixes: 337072604224 ("clk: mvebu: Expand mv98dx3236-core-clock support") Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/mvebu/mv98dx3236.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/mvebu/mv98dx3236.c b/drivers/clk/mvebu/mv98dx3236.c index 6e203af73cac1..c8a0d03d2cd60 100644 --- a/drivers/clk/mvebu/mv98dx3236.c +++ b/drivers/clk/mvebu/mv98dx3236.c @@ -174,7 +174,9 @@ static void __init mv98dx3236_clk_init(struct device_node *np) mvebu_coreclk_setup(np, &mv98dx3236_core_clocks); - if (cgnp) + if (cgnp) { mvebu_clk_gating_setup(cgnp, mv98dx3236_gating_desc); + of_node_put(cgnp); + } } CLK_OF_DECLARE(mv98dx3236_clk, "marvell,mv98dx3236-core-clock", mv98dx3236_clk_init); -- 2.20.1