From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1533BC35242 for ; Fri, 24 Jan 2020 09:56:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFACF2075D for ; Fri, 24 Jan 2020 09:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859784; bh=Nym0iD4z5NaCeFn5Wys1xYI74+4vhLSYjFRC9SEUaek=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=n5qpbA0PMqzPYl83osstpwHeQYhbYJM8k21Ut8Ob1SjuwcRB/dnLR/jIu/IJXpJLo S7pJ9Y6LxUvsEo8ceqFMraxtn/BICyXDC3U+1m4bQZuRWCbI0QjMkVmeSKtvaf9x4N sgOTbQWzAX6nsiBzgjYrkeISRvI3CcK/KYiIqGpc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388533AbgAXJ4Y (ORCPT ); Fri, 24 Jan 2020 04:56:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:60126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733156AbgAXJ4Y (ORCPT ); Fri, 24 Jan 2020 04:56:24 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7C60D20718; Fri, 24 Jan 2020 09:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859783; bh=Nym0iD4z5NaCeFn5Wys1xYI74+4vhLSYjFRC9SEUaek=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2oefFpxuUt4z3jBM3kM84L/2QTUCPid0IFm64oHMfBOoZLrUdr3+OIzis31F2xEa9 rYRcT5lQk42g+oHn2jjeAbagKdJR2pudTYAlW0Zw2IeSZBC+jVLV1KPUzDWMPY75Nt dZ8pnum9Gqib+7hbfmTxFRCZIWpQTmWvfRHGlrPQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Igor Konopko , =?UTF-8?q?Javier=20Gonz=C3=A1lez?= , Hans Holmberg , =?UTF-8?q?Matias=20Bj=C3=B8rling?= , Jens Axboe , Sasha Levin Subject: [PATCH 4.14 194/343] lightnvm: pblk: fix lock order in pblk_rb_tear_down_check Date: Fri, 24 Jan 2020 10:30:12 +0100 Message-Id: <20200124092945.501276564@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Igor Konopko [ Upstream commit 486b5aac85f6ec0b2df3e82a6a629d5eb7804db5 ] In pblk_rb_tear_down_check() the spinlock functions are not called in proper order. Fixes: a4bd217 ("lightnvm: physical block device (pblk) target") Signed-off-by: Igor Konopko Reviewed-by: Javier González Reviewed-by: Hans Holmberg Signed-off-by: Matias Bjørling Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/lightnvm/pblk-rb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/lightnvm/pblk-rb.c b/drivers/lightnvm/pblk-rb.c index c0dd17a821709..73de2deaba673 100644 --- a/drivers/lightnvm/pblk-rb.c +++ b/drivers/lightnvm/pblk-rb.c @@ -825,8 +825,8 @@ int pblk_rb_tear_down_check(struct pblk_rb *rb) } out: - spin_unlock(&rb->w_lock); spin_unlock_irq(&rb->s_lock); + spin_unlock(&rb->w_lock); return ret; } -- 2.20.1