From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D24F6C2D0DB for ; Fri, 24 Jan 2020 09:57:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A964920709 for ; Fri, 24 Jan 2020 09:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859875; bh=WdF6FmA4TY5goN8Y0YvbcIMclois3s/SStPTnr5kx10=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2GATT6NP2vIGaS32Qrw58/SMnF9/pg4KglETahjI1YNAowjY2xxeEG8SnvMpWNqMc Mzt9LCT7VaA/mJ52kCzJ0T2ilRikDoCl52jOydV/pS8Cr0fvHIkwTfszDCtQkHnzFg qCX5LDJ2qSLBCbs4riW0ZXJvSDkCzg3xoqxs5Ap4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731467AbgAXJ5y (ORCPT ); Fri, 24 Jan 2020 04:57:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:33486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729990AbgAXJ5x (ORCPT ); Fri, 24 Jan 2020 04:57:53 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 184C024125; Fri, 24 Jan 2020 09:57:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859873; bh=WdF6FmA4TY5goN8Y0YvbcIMclois3s/SStPTnr5kx10=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nph50Yrzns2tWui5e0JzhKN54wvPdy0B8pLUeu+NslgRhKdvIYJq3QUGRBs+aPStq vrJ4ez51TG6eUkSnVZc/bZlHV4o6BiW6yVffIWGoVIUCAAeWVdhAKzMOcEYYL8TgCq qXaKbcoZfQuVL0/6wCg8yLY7Bchqg32l3qDTIyAw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Mario Limonciello , Andy Shevchenko , Sasha Levin Subject: [PATCH 4.14 201/343] platform/x86: alienware-wmi: printing the wrong error code Date: Fri, 24 Jan 2020 10:30:19 +0100 Message-Id: <20200124092946.384793748@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit 6d1f8b3d75419a8659ac916a1e9543bb3513a882 ] The "out_data" variable is uninitialized at the point. Originally, this used to print "status" instead and that seems like the correct thing to print. Fixes: bc2ef884320b ("alienware-wmi: For WMAX HDMI method, introduce a way to query HDMI cable status") Signed-off-by: Dan Carpenter Reviewed-by: Mario Limonciello Signed-off-by: Andy Shevchenko Signed-off-by: Sasha Levin --- drivers/platform/x86/alienware-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c index cbd84e2e3bd47..2c82188f8486c 100644 --- a/drivers/platform/x86/alienware-wmi.c +++ b/drivers/platform/x86/alienware-wmi.c @@ -570,7 +570,7 @@ static ssize_t show_hdmi_source(struct device *dev, return scnprintf(buf, PAGE_SIZE, "input [gpu] unknown\n"); } - pr_err("alienware-wmi: unknown HDMI source status: %d\n", out_data); + pr_err("alienware-wmi: unknown HDMI source status: %u\n", status); return scnprintf(buf, PAGE_SIZE, "input gpu [unknown]\n"); } -- 2.20.1