From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45FDEC2D0DB for ; Fri, 24 Jan 2020 09:58:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C30C20718 for ; Fri, 24 Jan 2020 09:58:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859901; bh=+2g9AqdB+HbWQ6IxOSw80hrAf5/7XChX9Fm7zN8J8Ao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pPojQ5SJ5qVA4kJ+tmYiq54o88mS8pD9/HolnOU40LxnfoprzxHLTKY+LxC7tX4Xx jA8CEA77JSOLPBeitZjOSMhzzD8ohEOnJZextW9CUN1O2sWAXRRdskuTjHZ7QmtWyI N0eodLqHWngUwRAJ/lCjjYpk90dYKm8L3J2kZBjg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732903AbgAXJ6U (ORCPT ); Fri, 24 Jan 2020 04:58:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:33850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbgAXJ6T (ORCPT ); Fri, 24 Jan 2020 04:58:19 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7CCDB20709; Fri, 24 Jan 2020 09:58:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859899; bh=+2g9AqdB+HbWQ6IxOSw80hrAf5/7XChX9Fm7zN8J8Ao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IfHxF+Zbn2efo7XJnl33xHgf8w8HLWSpFDtQO2tP3zI8/OuggCkfla2Siu95An5tQ ioy8OdWpqDiH6Rsl7cTlk6IcM75CakrrViHy0qhB9ToMccQNLHEzpv5Ck+V3YgcqRg FnbYJZO6inOS4P6uNpTJ+cusSL2QJ+kkMTqdAs0A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bichao Zheng , Martin Blumenstingl , Neil Armstrong , Thierry Reding , Sasha Levin Subject: [PATCH 4.14 205/343] pwm: meson: Dont disable PWM when setting duty repeatedly Date: Fri, 24 Jan 2020 10:30:23 +0100 Message-Id: <20200124092946.983064282@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Bichao Zheng [ Upstream commit a279345807e1e0ae79567a52cfdd9d30c9174a3c ] There is an abnormally low about 20ms,when setting duty repeatedly. Because setting the duty will disable PWM and then enable. Delete this operation now. Fixes: 211ed630753d2f ("pwm: Add support for Meson PWM Controller") Signed-off-by: Bichao Zheng [ Dropped code instead of hiding it behind a comment ] Signed-off-by: Martin Blumenstingl Reviewed-by: Neil Armstrong Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin --- drivers/pwm/pwm-meson.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c index 9551f896dd6f3..3d2c36963a4fc 100644 --- a/drivers/pwm/pwm-meson.c +++ b/drivers/pwm/pwm-meson.c @@ -325,11 +325,6 @@ static int meson_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, if (state->period != channel->state.period || state->duty_cycle != channel->state.duty_cycle || state->polarity != channel->state.polarity) { - if (channel->state.enabled) { - meson_pwm_disable(meson, pwm->hwpwm); - channel->state.enabled = false; - } - if (state->polarity != channel->state.polarity) { if (state->polarity == PWM_POLARITY_NORMAL) meson->inverter_mask |= BIT(pwm->hwpwm); -- 2.20.1