From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF745C2D0DB for ; Fri, 24 Jan 2020 09:58:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9DFE222D9 for ; Fri, 24 Jan 2020 09:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859937; bh=S0DcZUB/dj1Ci2RayirlwC/ePHnKNOhILSazWcVMolU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Fsl0bMFpBLIqLcbmH8Dy4dEHkOZmOHJ1Uh38zcEZTe7DAo4pzXjXlZR/2llT4KyAC BOVIGhLPOskz41x/OjEufhxPTGYO4XsrDNapLT0RGK3K2vli8eO4gVUO+/ywJ+e3dp XPj1o1vbu7GkNj59eC9ZFLgPlFT5HB8yJcXNXO/g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731112AbgAXJ6y (ORCPT ); Fri, 24 Jan 2020 04:58:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:34450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbgAXJ6y (ORCPT ); Fri, 24 Jan 2020 04:58:54 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0E86120718; Fri, 24 Jan 2020 09:58:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859933; bh=S0DcZUB/dj1Ci2RayirlwC/ePHnKNOhILSazWcVMolU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t4ByzmZTl/vfStVr0BNdJymTUsO29KdBD7zyCnp6q56nkZIooS6kGghvjF4LBUx4R gmbLRqzjngo3lGpguuLXHta7NPoJyjLID9WtdjQmfeS4CUMdoyjSquDe4+zo1QXeu/ wj2cIdiFSaAAxzEab6OE8M0DmVko3xKlGFPgDbek= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lu Baolu , Joerg Roedel , Sasha Levin Subject: [PATCH 4.14 224/343] iommu: Use right function to get group for device Date: Fri, 24 Jan 2020 10:30:42 +0100 Message-Id: <20200124092949.600552033@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Lu Baolu [ Upstream commit 57274ea25736496ee019a5c40479855b21888839 ] The iommu_group_get_for_dev() will allocate a group for a device if it isn't in any group. This isn't the use case in iommu_request_dm_for_dev(). Let's use iommu_group_get() instead. Fixes: d290f1e70d85a ("iommu: Introduce iommu_request_dm_for_dev()") Signed-off-by: Lu Baolu Signed-off-by: Joerg Roedel Signed-off-by: Sasha Levin --- drivers/iommu/iommu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 4b761678a18bb..2c48a9d6d91e9 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -1856,9 +1856,9 @@ int iommu_request_dm_for_dev(struct device *dev) int ret; /* Device must already be in a group before calling this function */ - group = iommu_group_get_for_dev(dev); - if (IS_ERR(group)) - return PTR_ERR(group); + group = iommu_group_get(dev); + if (!group) + return -EINVAL; mutex_lock(&group->mutex); -- 2.20.1