From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0803DC2D0DB for ; Fri, 24 Jan 2020 10:07:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFEA820709 for ; Fri, 24 Jan 2020 10:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579860424; bh=RhfQlK83EeI/rq18MPKK9XrD6GLD155g4TXFZOUFpcY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TzWZdpXjKRQMp9YK/ZX3ELzujcMqxygu6HdF/QNAwMTEPfgt/z5u9erUJVRUTf3yj nhy3TfBE/pFFbWz6e24IrtGhIlBTVCH0Ysk8AcKMsX/ifL/QvGMjmiNFIZTE2oUd6v gCWOamVtZAVDVC+wTZqwA6TUXUhSb4KTIXpHyZMM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389215AbgAXKHE (ORCPT ); Fri, 24 Jan 2020 05:07:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:43542 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730766AbgAXKHA (ORCPT ); Fri, 24 Jan 2020 05:07:00 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7D1D20709; Fri, 24 Jan 2020 10:06:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579860419; bh=RhfQlK83EeI/rq18MPKK9XrD6GLD155g4TXFZOUFpcY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LsP7s38Ci2VHzSNl8qyMrJUO+P/o0DpPiTy7qWxMjoEQZvUocmvAHMsNMTY/3ULbS 4GWzrf1WKqAYwMeIg2adoS4bwG3Uq3hd0kKU5Z11696ePd/E3hn5zy9sT2TuhR3zBo ayVVXI/5PD9qcdyyNAKn29dxnHAmypvFpX9leVGY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Florian Fainelli , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 310/343] net: broadcom/bcmsysport: Fix signedness in bcm_sysport_probe() Date: Fri, 24 Jan 2020 10:32:08 +0100 Message-Id: <20200124093000.672708164@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit 25a584955f020d6ec499c513923fb220f3112d2b ] The "priv->phy_interface" variable is an enum and in this context GCC will treat it as unsigned so the error handling will never be triggered. Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver") Signed-off-by: Dan Carpenter Acked-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/bcmsysport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c index 79018fea7be24..69b2f99b0c19d 100644 --- a/drivers/net/ethernet/broadcom/bcmsysport.c +++ b/drivers/net/ethernet/broadcom/bcmsysport.c @@ -2116,7 +2116,7 @@ static int bcm_sysport_probe(struct platform_device *pdev) priv->phy_interface = of_get_phy_mode(dn); /* Default to GMII interface mode */ - if (priv->phy_interface < 0) + if ((int)priv->phy_interface < 0) priv->phy_interface = PHY_INTERFACE_MODE_GMII; /* In the case of a fixed PHY, the DT node associated -- 2.20.1